Bug 1603 - Evaluate actions of the Display view evaluate on empty selection (1GENSR6)
Summary: Evaluate actions of the Display view evaluate on empty selection (1GENSR6)
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 2.0   Edit
Hardware: All Windows 2000
: P2 major (vote)
Target Milestone: ---   Edit
Assignee: Joe Szurszewski CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2001-10-10 22:16 EDT by Darin Swanson CLA
Modified: 2001-10-31 19:09 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Swanson CLA 2001-10-10 22:16:06 EDT 
DS (6/1/01 3:35:32 PM)
	On 116

	Test Case
		Have a program running and paused at a breakpoint
		Go to the display view
		With nothing selected, hit the Inpsect or Display actions

An evaluation occurs on the empty String.

NOTES:
	GDA (6/5/01 11:40:48 AM)
		Defer

DS (10/10/2001 4:29:14 PM)
	This is still the current behaviour...but have proposal/prototype to select the entire current line
	of an empty selection.
	@see 1GJ6GR9: ITPDUI:ALL - Display window enhancement
Comment 1 Darin Wright CLA 2001-10-15 11:35:33 EDT 
Suggest not to select current line - we cannot infer what the user wants
to "inspect/display". However, we need to find out from EG, if action
should just be disabled when no selection, or if we should provide a
dialog explaining that an expression needs to be selected to be evaluated.
Comment 2 Darin Swanson CLA 2001-10-30 11:07:58 EST 
From EG
In your particular case of Display/Inspect:
* automatically expanding the selection to the line is not consistent with the 
rest of the platform.
In particular the user never sees this implicit selection and the wrong 
expression could
be executed by accident.
* recommend to just disable Display/Inspect when the selection is empty
* to simplify the execution of the recently entered text, we could provide a 
short-cut (ctrl-w)
that selects the text between the end of the last output and the current cursor 
position (see 5357)
Comment 3 Darin Swanson CLA 2001-10-30 11:38:21 EST 
Fixed.  Please verify in the display and Java Editor context menus and tool bars
Comment 4 Darin Swanson CLA 2001-10-30 11:47:01 EST 
And the snippet editor.
Comment 5 Joe Szurszewski CLA 2001-10-31 19:09:18 EST 
Verified in context menu and toolbar for snippet editor, in context menu and 
toolbar for DisplayView, and in context menu for java editor.