Bug 160216 - [IRC] Topic changes should be treated as a channel scope message
Summary: [IRC] Topic changes should be treated as a channel scope message
Status: CLOSED FIXED
Alias: None
Product: ECF
Classification: RT
Component: ecf.core (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 minor (vote)
Target Milestone: ---   Edit
Assignee: ecf.core-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2006-10-09 10:36 EDT by Remy Suen CLA
Modified: 2008-05-18 14:46 EDT (History)
1 user (show)

See Also:

Attachments
Patch to send the message to the channel instead. (2.17 KB, patch)
2006-10-09 10:38 EDT, Remy Suen CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Suen CLA 2006-10-09 10:36:44 EDT 
Topic changes are currently all outputted as server messages. This is incorrect since a topic is a channel-specific message.
Comment 1 Remy Suen CLA 2006-10-09 10:38:27 EDT 
Created attachment 51640 [details]
Patch to send the message to the channel instead.

This patch also adds a 'break;' to one of the cases for onReply. case 320 should probably be removed since I didn't notice any replies with 320 as an identification number in the RFCs, perhaps the person that wrote the code can offer some insight on that one.
Comment 2 Scott Lewis CLA 2006-10-09 17:01:57 EDT 
Fixed by applying Remy's patch.  Thanks!!  Will be in ECF 0.9.3.
Comment 3 Scott Lewis CLA 2006-11-16 13:56:54 EST 
closing and adding to ip log for patch