Community
Participate
Working Groups
When creating a pathmap using an instance of the org.eclipse.gmf.runtime.emf.ui.PathmapsPreferencePage (installed by my client application in the preferences dialog), the user has to click on the hyperlink to jump to the Linked Resources page in order to add a pathmap entry. The text that indicates this is a little oblique. It should be more direct, stating something like "To add a pathmap, use the Linked Resources page to define a path variable, then this page to associate it with modeling." As currently formulated, it is assuming that the user already has defined useful path variables for some independent reason, which in a modeling application is not generally the case. Alternatively (and to work around bug 81202, which is the reason why the Linked Resources page has no "Apply" button), it would be even nicer to be able to define the path variable on this page instead of having to do so on the Linked Resources page.
I assume that this is a 2.0 request given we are not supposed to add new strings.
Technically, an enhancement (though it is a priority).
Created attachment 59099 [details] Uses cases for enhanced pref page Attached an HTML document describing a proposal for the enhanced Path Maps preference page by way of use cases and screen captures.
Anthony, Cherie, Alan, Can you please review the attached ZIPped HTML document and comment on the proposed UI in this bug?
Looks good to me. Only comment: I think the caption needs to be: Choose or create path variable for use in modeling artifacts. (i.e. "in" not "for")
Looks good.
Looks good. One comment: In the "Edit a Pathmap" usecase step 2a should the dialog also indicate that the workspace Path Variable will be editted similar to when the user attempted to remove a pathmap?
Thanks, all, for your reviews (so prompt, too!). In reply to comment #5: thanks, that was an incomplete edit of an existing string. In reply to comment #7: that's a good idea. I'll be sure to mention in the directions at the top of both the "New Path Map Variable" and "Edit Path Map Variable" dialogs that these manipulate the workspace path variables. It wouldn't be a prompt dialog (as in the removal use case) in addition to the edit dialog.
Created attachment 59334 [details] Patch implementing the proposed design Attached a patch implementing the design proposed in the use case document (previous attachment). Includes resolution of Cherie's code-review comments: - add warning icon for non-existent path - verify keyboard navigation using tab and accelerators - confirm work-around for bug 76509 re: disabling table checkboxes - confirm no changes to public/protected API - delete unused messages - apply workspace path variable changes only on Apply/OK
Created attachment 59365 [details] Updated patch Attached an updated patch that fixes Javadoc problems in the previous patch (missing/incorrect documentation).
Committed Christian's patch. Tested accessibility with use of keyboard and screenreader.
Hi Christian, As part of this delivery, we need to review http://wiki.eclipse.org/index.php/GMF_New_and_Noteworthy#2.0_M5 (check that GMF tooling is generating the new preference page). We also need to update M5 new and noteworthy with this enhancement.
Done. http://wiki.eclipse.org/index.php/GMF_New_and_Noteworthy#Path_Maps_Preference_Page
[target cleanup] 2.0 M5 was the original target milestone for this bug
[GMF Restructure] Bug 319140 : product GMF and component Runtime was the original product and component for this bug
