Bug 1591 - Guess at breakpoint location not very good (1GET2PP)
Summary: Guess at breakpoint location not very good (1GET2PP)
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 2.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.0 M3   Edit
Assignee: Jared Burns CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 8473 12696 15067 26268 27150 (view as bug list)
Depends on:
Blocks:
 
Reported: 2001-10-10 22:15 EDT by Joe Szurszewski CLA
Modified: 2003-08-19 20:48 EDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joe Szurszewski CLA 2001-10-10 22:15:54 EDT 
JGS (6/4/01 11:58:37 AM)
	If I am trying to set a bp on last line of method, but miss and actually click in ruler on the closing {,
	the bp actually gets set on the next executable line, even though it is 3 lines down, whereas the 
	line I wanted is only 1 line above.  Shouldn't the guess at bp location be bidirectional?
Comment 1 Darin Wright CLA 2002-02-26 14:39:27 EST 
Deferred
Comment 2 Jared Burns CLA 2002-06-25 15:08:03 EDT 
Making the search bi-directional makes it more difficult for the user to 
predict where a breakpoint will be placed. If the user clicks on a line that 
is equidistant from executable lines above and below, the result is ambiguous.

Our current behavior is consistent and easy to understand. Move to close.
Comment 3 Darin Wright CLA 2002-06-26 11:13:24 EDT 
Breakpoint location verification has problem in general, and there are several 
related bugs. We need to have one bug report open (feature request) to improve 
breakpoint location verification.
Comment 4 Darin Wright CLA 2003-05-12 14:30:32 EDT 
Re-opening for 3.0. Should consider location verification while addressing 
external breakpoints.
Comment 5 Darin Wright CLA 2003-05-12 14:48:31 EDT 
*** Bug 8473 has been marked as a duplicate of this bug. ***
Comment 6 Darin Wright CLA 2003-05-12 15:32:15 EDT 
*** Bug 12696 has been marked as a duplicate of this bug. ***
Comment 7 Darin Wright CLA 2003-05-12 15:51:43 EDT 
*** Bug 15067 has been marked as a duplicate of this bug. ***
Comment 8 Darin Wright CLA 2003-05-14 11:24:27 EDT 
*** Bug 26268 has been marked as a duplicate of this bug. ***
Comment 9 Darin Wright CLA 2003-05-14 11:30:39 EDT 
*** Bug 27150 has been marked as a duplicate of this bug. ***
Comment 10 Luc Bourlier CLA 2003-08-18 15:11:18 EDT 
Fixed.
Changed the way the location of the breakpoint is checked, it now uses the JDOM.
The tree generated by the JDOM contains more details about the code, which help
to determine if a breakpoint can be set at the location.
Parsing the source to get the tree can be slow for huge files ( > 2000 lines of
code), so the verification is done in a Job. A breakpoint is first created at
the given location, then the location is checked. If needed, the breakpoint is
moved to a valid location, or removed (with notification to the user).

In the same time that a correct location is search, it resolve the name of type
which contains the location, to fix bug 13834.
Comment 11 Luc Bourlier CLA 2003-08-18 15:13:00 EDT 
Jared: there is nothing special to verify for this bug, I will give you to
verify the other bugs which contains test cases.
Comment 12 Jared Burns CLA 2003-08-19 20:31:23 EDT 
Fixed an off-by-one error in ManageBreakpointRulerAction.
Comment 13 Jared Burns CLA 2003-08-19 20:48:36 EDT 
Nothing special verified.