Bug 158948 - Opening of plug-in manifest editors and editor pages confusing
Summary: Opening of plug-in manifest editors and editor pages confusing
Status: RESOLVED DUPLICATE of bug 153515
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Brian Bauman CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-09-27 06:51 EDT by Markus Keller CLA
Modified: 2006-09-27 12:16 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2006-09-27 06:51:14 EDT 
I20060926-0935

Take a plugin with MANIFEST.MF and plugin.xml, e.g. org.eclipse.core.expressions.

- Doubleclick MANIFEST.MF
=> Editor opened on Overview page. I would prefer MANIFEST.MF page, but I can live with getting the Overview page on first open.

- doubleclick plugin.xml
=> A second editor is opened, also on Overview page. This is confusing:
   - I would expect that the previously opened editor is activated.
   - I would expect that the shown page shows the contents of plugin.xml, in
     any form. But the overview page has almost nothing to do with plugin.xml
     for new style plugins (only 2 links in Extensions section).

- switch to plugin.xml page
- File > Close All
- doubleclick MANIFEST.MF
=> Editor is opened on plugin.xml page. This is clearly wrong. The opened page should be MANIFEST.MF.

I guess PDE remembers the last opened page for manifest editors. It should remember the last pages separately for each file, or give me back the option to always show the source page by default (removed with bug 82057).
Comment 1 Brian Bauman CLA 2006-09-27 11:12:28 EDT 
PDE should not be opening two versions of the same editor.  This is definitely a bug and I will look into fixing this right away.

The Manifest Editor is now an all-in-one editor for the three files.  This helps simplify modifying these resource by not making the user open the files individually.  The editor opening on the wrong page is being tracked with bug 153515.  

Once the editor is open (and we use only one editor for a plugin.xml and Manifest), by double clicking on the Manifest it will reset the tab to the overview tab.  Also, in the same situation, double clicking the plugin.xml should reset the tab to the Extensions tab.  This is meant to show the form editor tab most related to the file which was clicked.  PDE gives preference to the UI form editor over the source page since it is more user friendly for most users.

If you always want your Manifest.MF and plugin.xml to always open to source, you can also use the text editor for each file.
Comment 2 Brian Bauman CLA 2006-09-27 12:16:49 EDT 
Opened bug 158992 to track the two editors opening.  Marking as duplicate since intent of this bug report was confusion with tabs when opening Manifest editor (not othe opening of two editors).

*** This bug has been marked as a duplicate of 153515 ***