Bug 158743 - SQLParserManager.setPostParseProcessors
Summary: SQLParserManager.setPostParseProcessors
Status: CLOSED FIXED
Alias: None
Product: Data Tools
Classification: Tools
Component: SQL Query Parser (show other bugs)
Version: 0.9   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 1.6M5   Edit
Assignee: Brian Payton CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2006-09-26 09:24 EDT by Cristian Dobre CLA
Modified: 2008-04-25 15:37 EDT (History)
0 users

See Also:


Attachments
Patch for o.e.d.sqltools.parsers.sql plugin (1.13 KB, patch)
2007-12-20 22:30 EST, Brian Payton CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Cristian Dobre CLA 2006-09-26 09:24:42 EDT
Could you please check method SQLParserManager.setPostParseProcessors

I guess the condition should be

if ((postParseProcessors == null) || (postParseProcessors.size() == 0) ) {
    postParseProcessors = getInternalDefaultPostParseProcessorList();
}

I can set the postParseProcessors to an empty list and this will skip default post parsing...

        // we always want to post parse process, at least the basic stuff! so
        // postParseProcessors == null really means
        // postParseProcessors == getInternalDefaultPostParseProcessorList()
        // but we want to hide that from the public
        if (postParseProcessors == null) {
            postParseProcessors = getInternalDefaultPostParseProcessorList();
        }


plugins/
org.eclipse.datatools.sqltools.parsers.sql_0.9.0.200605101/sqlparser.jar

package org.eclipse.datatools.sqltools.parsers.sql;

public abstract class SQLParserManager {
    
    /**
     * Sets the post parse processors used for semantical checks and resolvings
     * after successful syntactical parsing.
     * 
     * @param postParseProcessors
     */
// ********
    public final void setPostParseProcessors(List postParseProcessors)
    {
        // we always want to post parse process, at least the basic stuff! so
        // postParseProcessors == null really means
        // postParseProcessors == getInternalDefaultPostParseProcessorList()
        // but we want to hide that from the public
        if (postParseProcessors == null) {
            postParseProcessors = getInternalDefaultPostParseProcessorList();
        }
        this.postParseProcessors = postParseProcessors;
    }
// ********
}
Comment 1 Hui Cao CLA 2007-07-12 02:56:24 EDT
Reassigned to Brian.
Comment 2 Brian Payton CLA 2007-12-20 22:30:45 EST
Created attachment 85697 [details]
Patch for o.e.d.sqltools.parsers.sql plugin
Comment 3 Brian Payton CLA 2007-12-20 22:35:48 EST
Applied suggested change to SQLParserManager class in the 1.6M5 code stream.  Set the plugin version to 1.0.0.200712201.
Comment 4 Brian Payton CLA 2008-04-25 15:37:56 EDT
Closing...