Bug 158623 - [performance] ComponentDeployable members() to recognize "optimized" structure
Summary: [performance] ComponentDeployable members() to recognize "optimized" structure
Status: CLOSED FIXED
Alias: None
Product: WTP Java EE Tools
Classification: WebTools
Component: jst.j2ee (show other bugs)
Version: 1.5   Edit
Hardware: PC Windows XP
: P1 critical (vote)
Target Milestone: 1.5.2 M152   Edit
Assignee: John Lanuti CLA
QA Contact: Chuck Bridgham CLA
URL:
Whiteboard: PMC_approved
Keywords: performance
: 158622 159035 (view as bug list)
Depends on:
Blocks:
 
Reported: 2006-09-25 14:15 EDT by Chuck Bridgham CLA
Modified: 2006-10-20 10:03 EDT (History)
6 users (show)

See Also:


Attachments
Proposed Patch (12.58 KB, patch)
2006-10-06 16:31 EDT, John Lanuti CLA
no flags Details | Diff
Proposed patch (12.62 KB, patch)
2006-10-09 10:57 EDT, John Lanuti CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chuck Bridgham CLA 2006-09-25 14:15:30 EDT
Current members() api uses flexible project api to aggregate all folder/file content, which can be very slow with large workspaces.   members() method may have optimization that should be investigated, but recognizing the Module is already in an optimized state, and populating the IModule files by traversing a single root will greatly improve performance.
Comment 1 John Lanuti CLA 2006-10-02 16:24:23 EDT
*** Bug 158622 has been marked as a duplicate of this bug. ***
Comment 2 John Lanuti CLA 2006-10-03 11:41:00 EDT
*** Bug 159035 has been marked as a duplicate of this bug. ***
Comment 3 John Lanuti CLA 2006-10-06 16:31:49 EDT
Created attachment 51581 [details]
Proposed Patch
Comment 4 John Lanuti CLA 2006-10-09 10:57:59 EDT
Created attachment 51643 [details]
Proposed patch

Updated patch with comments from Chuck about only caring about non manifest references in web projects in the check for optimized structure.  We should never be concerned with manifest references because they are not packaged in the current component.
Comment 5 John Lanuti CLA 2006-10-09 13:23:17 EDT
The J2EEFlexProjDeployable, which handles J2EE publish deploying, needs to be smarter.  If it detects that it is in an optimized structure, generally, meaning one content root and one output folder, that are also the same folder, then instead of having to go through expensive virtual API, we can just pass the root folder contents to the server deploy tools.  This will considerably improve time to publish and deploy on the server, especially in larger workspaces.  The patch is attached and has good documentaion embedded explaining the changes.
Comment 6 Jason Sholl CLA 2006-10-09 14:27:39 EDT
approve
Comment 7 Chuck Bridgham CLA 2006-10-09 14:51:54 EDT
approve
Comment 8 David Williams CLA 2006-10-09 20:20:38 EDT
+1
Comment 9 John Lanuti CLA 2006-10-10 11:00:36 EDT
This is released to the 2.0 and 1.5.2 streams for the 101106 builds based on PMC feedback from David Williams.
Comment 10 Arthur Ryman CLA 2006-10-10 15:54:36 EDT
+1 for WTP 1.5.2.

Why are you releasing with just one vote? You need to allow adequate time for PMC review.
Comment 11 Naci Dai CLA 2006-10-11 11:06:42 EDT
+1 for 1.5.2
Comment 12 Raghunathan Srinivasan CLA 2006-10-12 14:54:40 EDT
+1
Comment 13 Tim Wagner CLA 2006-10-12 16:05:39 EDT
+1
Comment 14 Neeraj Agrawal CLA 2006-10-20 09:44:33 EDT
verified
Comment 15 John Lanuti CLA 2006-10-20 10:03:47 EDT
Closing.