Description Darin Swanson 2001-10-10 22:15:43 EDT

DS (5/21/01 10:51:52 AM)
	When selecting a new context, the current context should be selected.

DW (5/24/01 9:35:14 PM)
	Fixed.

JGS (5/29/01 4:16:15 PM)
	This works for real packages and package fragments, but for default packages,
	if I select the default package for my project, then come back in, the default
	package for rt.jar is selected.

DW (5/30/01 1:58:34 PM)
	Not easily improved. The interaction between the "run in package" action and
	the scrapbook is via package name - not package handles. Would require
	changing the interaction to use element handle, and persisting the handle id.

DW (5/30/01 3:04:47 PM)
	Deferred to post-june.

DW (8/10/01 11:09:22 AM)
	This is a non-breaking change that we can fix in ZRH code.
	
JGS (8/15/01 3:22:09 PM)
	Made changes to RunInPackageAction and JavaSnippetEditor to persist the IPackageFragment
	handle identifier instead of just the package name.  Outstanding problem is that the SelectionDialog
	returned by JavaUI.createPackageDialog() only seems to take package names in its
	setInitialSelection() method.  We need a way to set the intial selection on the dialog with the
	actual IPackageFragment.  Sent mail to EG for advice.

JGS (8/16/01 5:13:15 PM)
	Changes made to JavaSnippetEditor:

	Changed member def:
		private String fPackageHandle= null;

	Changed method def:
		protected void doSetInput(IEditorInput input) throws CoreException {
			super.doSetInput(input);
		fPackageHandle = getPage().getPersistentProperty(new QualifiedName(JavaPlugin.getPluginId(), PACKAGE_CONTEXT));
		}

	Changed methods def:
	/**
	 * Set the handle identifier of the run-in package fragment
	 */
	public void setPackage(String packageHandle) {
		fPackageHandle= packageHandle;
		// persist
		try {
			getPage().setPersistentProperty(new QualifiedName(JavaPlugin.getPluginId(), PACKAGE_CONTEXT), packageHandle);
		} catch (CoreException e) {
			ErrorDialog.openError(getShell(), SnippetMessages.getString("SnippetEditor.error.packagecontext"), null, e.getStatus()); //$NON-NLS-1$
		}
	}
	
	/**
	 * Get the handle identifier of the run-in package fragment
	 */
	public String getPackage() {
		return fPackageHandle;
	}
	
	Changed method def:
	protected IEvaluationContext getEvaluationContext() {
		if (fEvaluationContext == null) {
			IJavaProject project= getJavaProject();
			fEvaluationContext= project.newEvaluationContext();
		}
		if (fPackageHandle != null) {	
			String packageName = JavaCore.create(fPackageHandle).getElementName();	
			fEvaluationContext.setPackageName(packageName);
		}
		return fEvaluationContext;
	}

	Changes made to RunInPackageAction:
		Changed methods def:	
	/**
	 * The user has invoked this action.
	 */
	public void run() {
		Shell s= fEditor.getSite().getShell();
		IPackageFragment result= choosePackage(s);
		if (result != null) {
			fEditor.setPackage(result.getHandleIdentifier());
		}
	} 

	private IPackageFragment choosePackage(Shell shell) {
		try {
			IJavaProject p= fEditor.getJavaProject();
			//fix for 1G472LK: ITPJUI:WIN2000 - Package selection dialog must qualify package names regarding source folders
			SelectionDialog dialog= JavaUI.createPackageDialog(shell, p, IJavaElementSearchConstants.CONSIDER_BINARIES);
			dialog.setTitle(SnippetMessages.getString("RunInPackage.dialog.title")); //$NON-NLS-1$
			dialog.setMessage(SnippetMessages.getString("RunInPackage.dialog.message")); //$NON-NLS-1$
			String pkgHandle= fEditor.getPackage();
			if (pkgHandle != null) {
				//String pkgName = JavaCore.create(pkgHandle).getElementName();
				IPackageFragment pf = (IPackageFragment)JavaCore.create(pkgHandle);
				dialog.setInitialSelections(new Object[] {pf});
			}
			dialog.open();		
			Object[] res= dialog.getResult();
			if (res != null && res.length > 0) 
				return (IPackageFragment)res[0];
		} catch (JavaModelException e) {
		}
		return null;
	}

JGS (8/17/01 10:42:55 AM)
	Need to integrate above code, as well as whatever fix is found for setting initial selection on dialog.

JGS (8/20/01 9:43:14 AM)
	New PR created to address inability to set initial selection.
	[1GIRGYV: ITPJUI:WIN2000 - SelectionDialog.setInitialSelection broken for all JDT dialogs]