Description Stephan Herrmann 2006-09-20 10:24:31 EDT

In class BlockScope I found several occurrences of this snippet:
 if (!binding.isValidBinding())
    return new ProblemReferenceBinding(
          CharOperation.subarray(compoundName, 0, currentIndex),
          null, // TODO should improve
          binding.problemId());

See e.g. method getBinding(char[][],int,InvocationSite,boolean)

To me it looks like the "null" could simply be replaced by
          ((ProblemReferenceBinding)binding).closestMatch
The binding should be a ReferenceBinding in all these locations,
so the cast should be safe (?).

If, e.g., the problemId() is NotVisible, other parts of the system
should be allowed to assume that the problem binding has indeed a
closestMatch, shouldn't they?