Bug 157394 - [Commands] CompositeCommand doesn't use progressMonitors correctly
Summary: [Commands] CompositeCommand doesn't use progressMonitors correctly
Status: NEW
Alias: None
Product: GMF-Runtime
Classification: Modeling
Component: General (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal
Target Milestone: 2.1   Edit
Assignee: Anthony Hunter CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-09-14 16:32 EDT by Min Idzelis CLA
Modified: 2010-07-19 21:58 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Min Idzelis CLA 2006-09-14 16:32:59 EDT 
In  org.eclipse.gmf.runtime.common.core.command.CompositeCommand, the doExecute() supplies a subProgressMonitor to the sub command to be run, after it finishes, it also tells the progressMonitor (that is the parent of the sub progress monitor) that is worked(1). This is wrong. That is because when you use sub progress monitors, the completion of the sub progress monitor sends the amount of work to the parent automatically. This is causing progress to to inccorectly reported.
Comment 1 Anthony Hunter CLA 2006-09-15 13:15:59 EDT 
So you are looking for us to remove the worked(1)?
Comment 2 Min Idzelis CLA 2006-09-15 13:19:51 EDT 
yes
Comment 3 Anthony Hunter CLA 2007-06-19 11:44:24 EDT 
Moving to the next release, GMF 2.1.
Comment 4 Eclipse Webmaster CLA 2010-07-19 21:58:06 EDT 
[GMF Restructure] Bug 319140 : product GMF and component
Runtime was the original product and component for this bug