Bug 157170 - [AST visitor] Unvisited elements
Summary: [AST visitor] Unvisited elements
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.3   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 3.3 M3   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-09-13 09:52 EDT by Nicolas Petitprez CLA
Modified: 2006-10-30 03:52 EST (History)
0 users

See Also:

Attachments
Proposed fix (95.04 KB, patch)
2006-10-13 15:18 EDT, Olivier Thomann CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nicolas Petitprez CLA 2006-09-13 09:52:13 EDT 
While scanning a org.eclipse.jdt.internal.compiler.ast.TypeDeclaration, we try to scan Annotation with ClassScope, but Annotation doesn't define traverse(ASTVisitor visitor, ClassScope scope) method. So the type's annotations are never scan.
Comment 1 Olivier Thomann CLA 2006-09-13 10:49:46 EDT 
Fix is trivial.
Comment 2 Olivier Thomann CLA 2006-09-14 16:37:13 EDT 
Moving target milestone to 3.3M3 since the change is bigger than expected.
Comment 3 Olivier Thomann CLA 2006-10-13 15:17:37 EDT 
Released for 3.3M3.
Regression tests added in org.eclipse.jdt.core.tests.compiler.regression.ASTImplTests#test0017/0018.
Comment 4 Olivier Thomann CLA 2006-10-13 15:18:55 EDT 
Created attachment 51970 [details]
Proposed fix

The patch that has been released.
Comment 5 Olivier Thomann CLA 2006-10-27 20:51:31 EDT 
This patch is adding too many methods. I am reviewing it.
Should be released tonight.
Comment 6 David Audel CLA 2006-10-30 03:52:48 EST 
Verified for 3.3 M3 using build I20061030-0010