Community
Participate
Working Groups
The Eclipse AJDT give an incorrect warning when you want to advise a private method of a private inner class. When I want to advise a private method in a private inner class, like this public class Outer { private class Inner { private void myMethod() } } Using the following poincut: poincut innerpointcut():execution( * Outer.Inner.myMethod() ); and advice: before():innerpointcut() { System.out.println( "executing!" ); } I get a warning "invalidAbsoluteTypeName" next to my pointcut, but next to the advice, there is a marker that points to the private method.
take a look for 1.5.3
This problem is occurring because Outer is in a package. Changing the pointcut expression to include the package ie. pkg.Outer.Inner.myMethod() or moving Outer to the default package does not produce the invalidAbsoluteTypeName warning. Also, note that the test programs for bug 67591 and bug 65925 which have previously been fixed also produce the invalidAbsoluteTypeName warning if the classes are in packages. The reason we're producing the warning is that at this time we're looking at Outer.Inner which we can't find, whereas when we come to match this has become pkg.Outer.Inner which we can find (and is why the marker is there indicating its been advised).
The reason we're getting the invalidAbsoluteTypeName is the same as we were getting the warning in bug 67591. That is, due to the visibility checking in org.eclipse.jdt.internal.compiler.lookup.ReferenceBinding.canBeSeenBy(). We find Outer.Inner, however, since this is a private class we check for the privileged modififier on the aspect. This isn't there so we return a ProblemReferenceBinding which ultimately results in the warning being reported. The fix for bug 67591 was to check if the type can be found in the world if there's a problem finding it from the current scope. This currently doesn't work in the case of this bug because, as previously mentioned, the class is in a package. When we come to see if the type Outer$Inner is in the world we ask the world's typemap for LOuter$Inner. However, the typemap contains Lpkg/Outer$Inner which doesn't match so we return that we can't find it in the world. A MissingResolvedTypeWithKnownSignature is created and the invalidAbsoluteTypeName warning is the result.
The problem is though that when we're resolving the pointcut, the pointcut expression contains "Outer.Inner.myMethod()" which makes no reference to the package...
The reason we know about the package when we come to match is that after reporting the warning we record scope.getImportedPrefixes(). In the case of the supplied testcase this includes pkg$A, pkg., java.lang.Object$ and java.lang. The fix is to update lookupTypeInWorld to include a search for the typename prepended with these prefixes.
Created attachment 51328 [details] failing testcases Apply this patch to the tests project. This patch contains four scenarios: 1. There is one file containing public aspect and a class. The class contains a private inner class which contains a private method. There should be no warning from the pointcut about not being able to find the type corresponding to the inner class. 2. The class and aspect are in different packages. The class has default visibility and contains a private method. The aspect imports the package containing the class. There should be no warning from the pointcut about not being able to find the class type. 2. The class and aspect are in different packages. The class has default visibility and contains a private method. The aspect does not import the package containing the class. There should be a warning from the pointcut about not being able to find the class type. 4. The class and aspect are are in the same package but different files. The class has default visibility and contains a private method. There should be no warnings saying cant find the class type.
Created attachment 51329 [details] proposed fix Apply this patch to the weaver project. This patch contains the proposed fix as described in comment #5.
patches in iplog
fixed in latest aj dev builds.
