Bug 156681 - no possibility of tool integrators contributing fine grained context sensitive help for their toolchains
Summary: no possibility of tool integrators contributing fine grained context sensitiv...
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-core (show other bugs)
Version: 3.1.1   Edit
Hardware: PC Windows XP
: P3 normal with 1 vote (vote)
Target Milestone: 3.1.1   Edit
Assignee: Doug Schaefer CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2006-09-08 06:11 EDT by Crispin Semmens CLA
Modified: 2009-01-09 16:59 EST (History)
0 users

See Also:

Attachments
allow tool integrators to supply context help for tool options (12.77 KB, patch)
2006-09-08 06:32 EDT, Crispin Semmens CLA 		bjorn.freeman-benson: iplog+
Details | Diff
fixing a bodged merge (1013 bytes, patch)
2006-09-18 08:44 EDT, Crispin Semmens CLA 		bjorn.freeman-benson: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Crispin Semmens CLA 2006-09-08 06:11:15 EDT 
The CDT doesn't have any mechanism for tool integrators to supply context help for their toolchains, such as contexts for tools, or tool options etc.
Obviously, the closer we can bring user assistance to the site where assistance is needed, the better.
Small patch coming up.
Comment 1 Crispin Semmens CLA 2006-09-08 06:32:59 EDT 
Created attachment 49702 [details]
allow tool integrators to supply context help for tool options

- added an element to the buildDefinitions schema allowing tool options to specify a context id to enable context sensitive help. (eg, compiler settings in the form of boolean options, combo boxes etc.)
- when no context is supplied, the behaviour is unchanged from previously.
Comment 2 Doug Schaefer CLA 2006-09-14 23:02:10 EDT 
I have applied these patches. Crispin, please test Friday's build to make sure the changes you want have been done correctly. Thanks.
Comment 3 Crispin Semmens CLA 2006-09-18 04:08:07 EDT 
(In reply to comment #2)
> I have applied these patches. Crispin, please test Friday's build to make sure
> the changes you want have been done correctly. Thanks.
> 

Thanks Doug. As far as I can tell, the other patches were applied fine. Sadly, Norbert Ploett seems to have trodden on the changes to managedbuilder.core/schema/buildDefinitions.exsd, which makes testing this patch application impossible. (there were issues with it being listed as binary instead of text, which he correctly fixed, neglecting to merge in my changes in the process.)

I've reopened the bug until this is resolved.

cheers,
Crispin
Comment 4 Doug Schaefer CLA 2006-09-18 07:43:31 EDT 
Could you please send a new patch against the lasted 3.1 bits. Thanks.
Comment 5 Crispin Semmens CLA 2006-09-18 08:44:57 EDT 
Created attachment 50363 [details]
fixing a bodged merge

hi Doug,

Here's the patch.

I hope this is enough to solve the problem. (it contains only the mistake, ever other item in the previous patch remains intact)
Comment 6 Crispin Semmens CLA 2006-09-20 08:36:04 EDT 
(In reply to comment #4)
> Could you please send a new patch against the lasted 3.1 bits. Thanks.
> 

Norbert just corrected the error, so the patch (id=50363) is no longer necessary. I'll look out for the next nightly build and close the bug if everything tests OK.
Comment 7 Crispin Semmens CLA 2006-09-22 06:48:11 EDT 
> Thanks Doug. As far as I can tell, the other patches were applied fine. Sadly,
> Norbert Ploett seems to have trodden on the changes to
> managedbuilder.core/schema/buildDefinitions.exsd, which makes testing this
> patch application impossible.

Actually, the schema isn't strictly required, you can still supply the contextId attribute (and it works in the 200609151512 build). So until the schema is factored into the build the context help contribution functionality exists, but only in stealth mode...
Comment 8 Doug Schaefer CLA 2006-09-25 13:35:39 EDT 
Patch applied to HEAD and CDT 3.1.1.