Bug 155886 - ActionFilterService should cut down on calls to ISelection::equals()
Summary: ActionFilterService should cut down on calls to ISelection::equals()
Status: RESOLVED FIXED
Alias: None
Product: GMF-Runtime
Classification: Modeling
Component: General (show other bugs)
Version: 1.0   Edit
Hardware: PC Windows XP
: P3 normal
Target Milestone: 1.0.1   Edit
Assignee: Yasser Lulu CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed, performance
Depends on:
Blocks:
 
Reported: 2006-08-31 15:09 EDT by Yasser Lulu CLA
Modified: 2010-07-19 21:55 EDT (History)
0 users

See Also:


Attachments
using identity equals first before resorting to calling ISelection::equals() (1.40 KB, patch)
2006-08-31 15:11 EDT, Yasser Lulu CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yasser Lulu CLA 2006-08-31 15:09:21 EDT
Currently when the ActionFilterService tries to figure out if the current selection has changed it calls equals() on the cached selection and the current selection, which is fine, however, when the selection in large the equals() method could take long time to complete, so, the proposed patch tries to test for equality using identity comparison of the ISelections first and if they are not equal then it will resort to using equals() method. This minimizes the calls to ISelection::equals() when the cached selection and the current selection are one and the same instance of ISelection
Comment 1 Yasser Lulu CLA 2006-08-31 15:11:26 EDT
Created attachment 49204 [details]
using identity equals first before resorting to calling ISelection::equals()
Comment 2 Yasser Lulu CLA 2006-08-31 16:16:20 EDT
The patch got committed
Comment 3 Richard Gronback CLA 2006-09-28 15:47:18 EDT
Committed by mmostafa, according to CVS log entry.  Adding contributed keyword
for IP log automation.
Comment 4 Eclipse Webmaster CLA 2010-07-19 21:55:53 EDT
[GMF Restructure] Bug 319140 : product GMF and component
Runtime Common was the original product and component for this bug