Bug 155885 - File location not set for schema object imported with properties sheet
Summary: File location not set for schema object imported with properties sheet
Status: CLOSED FIXED
Alias: None
Product: WTP Source Editing
Classification: WebTools
Component: wst.xsd (show other bugs)
Version: 1.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.0 M6   Edit
Assignee: Keith Chong CLA
QA Contact: Keith Chong CLA
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2006-08-31 15:08 EDT by Trung CLA
Modified: 2008-04-24 00:45 EDT (History)
0 users

See Also:

Attachments
for org.eclipse.wst.xsd.ui (2.76 KB, patch)
2006-09-03 00:34 EDT, Trung CLA 		no flags Details | Diff
for org.eclipse.wst.xsd.ui (4.57 KB, patch)
2006-09-03 01:26 EDT, Trung CLA 		no flags Details | Diff
for 'org.eclipse.xsd.ui' (4.85 KB, patch)
2008-03-18 18:24 EDT, Trung CLA 		bjorn.freeman-benson: iplog+
Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Trung CLA 2006-08-31 15:08:20 EDT 
To reproduce:
- Set a break point in createFileMap() of XSDSearchListProvider

- Follow the following steps:
1) Using XML examples
2) open GolfCountryClub
3) import SpaceWarGame into GolfCountryClub using desing view and properties
sheet
4) open Browse to set Type for any element
5) change the scope to Project or Workspace
6) Break point is hit, now check the location of the imported SpaceWarGame schema object with the debugger. It's null
Comment 1 Trung CLA 2006-09-03 00:34:53 EDT 
Created attachment 49302 [details]
for org.eclipse.wst.xsd.ui

The problem occurs because creating xsdSchema object using XSDParser doesn't set the location field for the xsdSchema object.

I changed code to use resource set to parse the xsdSchema object..
This should completely fixes Bug 144359
Comment 2 Trung CLA 2006-09-03 01:26:03 EDT 
Created attachment 49303 [details]
for org.eclipse.wst.xsd.ui

This patch produces all the warning about namespace when choosing files to be included or imported by using/copying part of the old code.
Comment 3 Trung CLA 2006-09-03 01:28:23 EDT 
I did not touch the case when the imported file is from http:// ...
not from a file from the workspace
Comment 4 Keith Chong CLA 2006-09-05 15:47:07 EDT 
Assigned to Trung
Comment 5 David Williams CLA 2006-10-26 04:51:18 EDT 
mass update to remove target for all those targeted to 1.5.3 that were "normal" severity and "priority 3" (on the surface those dont' seem serious enough to fix in a maintenance release). 

If I have made an error pleasae reset target and set priority appropriately.
Comment 6 Trung CLA 2008-03-18 18:24:05 EDT 
Created attachment 92851 [details]
for 'org.eclipse.xsd.ui'

New patch, no conflict.
Comment 7 Keith Chong CLA 2008-03-25 20:17:12 EDT 
Trung, see my changes to XSDImportSection.
Comment 8 Keith Chong CLA 2008-04-04 14:35:06 EDT 
Verified fix is in S-3.0M6-20080404063211
Comment 9 David Williams CLA 2008-04-24 00:45:23 EDT 
mass change to add 'contributed' keyword based on bugzilla query, please correct if that's not accurate (by marking patches as obsolete and removing the 'contributed' keyword.