Bug 15563 - CompletionEngine does not report type packages of local variables
Summary: CompletionEngine does not report type packages of local variables
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 2.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 2.0 M6   Edit
Assignee: David Audel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-05-08 13:58 EDT by Andrew McCullough CLA
Modified: 2002-05-17 04:39 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew McCullough CLA 2002-05-08 13:58:59 EDT 
BUILD: 05022002

While working on some code completion enhancements (bug 9100), I noticed that 
the completion engine does not report packages for local variables.  

Although I don't know for sure, I think this was put in to prevent NPE when the 
local var type has not been resolved (qualified name, no import).  Is there 
something more to this, or is the code below OK?  I have been running with 
the "fix" for a couple days now, and no ill effects so far :)

I added the following line: 

local.type == null ? NoChar : local.type.qualifiedPackageName(),

near line 2348 (I can't be sure I didn't change the line number, but just look 
for "requestor.acceptLocal"
Comment 1 David Audel CLA 2002-05-17 04:39:35 EDT 
Your fix is good for me.

Fixed.