Community
Participate
Working Groups
Actually maximum size set in gmfgraph model for top-level nodes does not affect actual maximum size for figures at diagram -- instead user should adjust DefaultSizeAttributes for ViewMap in GenModel. Expected: It would be better if ViewmapProducer suggest the DefaultSizeAttributes in this case. It was originally requested in news group (see news:62b8f1200e62d9657aee959bbc1b8d77$1@www.eclipse.org).
NOTE: This may affect reconciler, because reconciler has general problems while processing derived values.
Hmm, it seems to be too greedy to always choose the biggest possible size :) Thus, if preferred size is set, than producer should use _preferred_ size.
Created attachment 48746 [details] Fixes the subj
reviewed and committed.
It would be even better to have special purpose facet in gmfgraph to define the default size for some diagram node. The usage of Figure#preferredSize is not buggy itself, but it forces generated figure to have this given preferred size even if it contents does not fit it. Consider Actions in activity diagrams. There are 20+ types of actions that share most of visual properties. It is the reason for them to share the diagram node in the gmfgraph model. It is unconvenient to set DefaultSizeAttributes 20+ times for each action, so it still should be deduced somehow. But if it is configured via preferred size, than action figure lose ability to expand together with its name label. Thus, it is proposed to defaine ad hoc facet class in the gmfgrph model and use its value to deduce default size.
Created attachment 49260 [details] Fixes the last reopen note
reviewed and committed
[GMF Restructure] Bug 319140 : product GMF and component Models was the original product and component for this bug
