Bug 155215 - [internal API] JUnitClientDelegate makes dubious use of internal non-API
Summary: [internal API] JUnitClientDelegate makes dubious use of internal non-API
Status: CLOSED DUPLICATE of bug 255517
Alias: None
Product: WTP ServerTools
Classification: WebTools
Component: jst.server (show other bugs)
Version: 1.5   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: Tim deBoer CLA
QA Contact: Chuck Bridgham CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-08-25 08:48 EDT by David Williams CLA
Modified: 2011-01-20 10:23 EST (History)
5 users (show)

See Also:

Attachments
Remove reference to JUnitBaseLaunchConfiguration from JUnitClientDelegate (3.27 KB, patch)
2006-11-30 17:16 EST, David Gorton CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Williams CLA 2006-08-25 08:48:29 EDT 
JUnitClientDelegate uses several constants from an internal, non-API class. 

On the surface, this seem unnecessary. Can't we in servlet UI define our own strings and use them instead?
Comment 1 David Williams CLA 2006-08-25 08:53:06 EDT 
Dan, can this problem be fixed? (by us ... not sure its a worthy API request, since just strings).
Comment 2 David Williams CLA 2006-08-30 11:57:47 EDT 
Rob, can you please take a look? Should be easy to fix, I think.
Comment 3 David Gorton CLA 2006-11-30 17:16:10 EST 
Created attachment 54834 [details]
Remove reference to JUnitBaseLaunchConfiguration from JUnitClientDelegate

This seems it might break some of the Cactus Test functionality if we are setting attributes that need to be detected by the JUnit plugin. 

Thanks.
Comment 4 Konstantin Komissarchik CLA 2007-04-27 11:55:07 EDT 
Tim,

Could you review this patch?
Comment 5 Tim deBoer CLA 2007-05-07 22:11:07 EDT 
The actual code looks fine and solves the problem. However, since I've never worked on this code I can't comment on whether this would cause any functional issues as David G suggested.
Comment 6 John Lanuti CLA 2007-06-12 10:14:01 EDT 
This sounds too risky given we are in shutdown for 2.0.  Deferring.
Comment 7 Tim deBoer CLA 2008-04-14 10:19:16 EDT 
This bug has been bouncing around long enough with the target continually moving. The original contributor of the Cactus code is long gone, and BEA has been unable to find another contributor. We either need to:

 * Start removing the Cactus support due to lack of interest.
 * Apply the patch with minimal testing.
 * Reject and close this bug.

If anyone has a strong opinion, please reply now. Otherwise, I'll deal with this bug.
Comment 8 Tim deBoer CLA 2008-05-28 08:55:44 EDT 
Removing 3.0 target and taking ownership of the bug. Since the original contributors are no longer interested in Cactus we'll probably deprecate or remove in 3.1.
Comment 9 Angel Vera CLA 2009-02-02 14:10:56 EST 
As part of an effort in improving quality, we are reviewing all bugs opened before June 1st, 2008, where the severity is set to "Major" or higher; and the bug does not contain a targeted milestone. 

When reviewing the bugs, this bug was identified with the above qualities. Review this bug and update according the following options: 

* Target to a specific release.  Specify "future" if you are planning to fix it, but not in the next release
* Adjust severity as appropriate
Comment 10 Angel Vera CLA 2009-02-04 15:31:20 EST 
Following the comments in #7, there is currently an effort in bug# 255517 to remove cactus from WTP. Resolving bug# 255517 will probably resolve this problem. 

I am closing this as dup.


*** This bug has been marked as a duplicate of bug 255517 ***
Comment 11 Tim deBoer CLA 2011-01-20 10:23:50 EST 
Closing old bugs.