Bug 1552 - Method entry breakpoints and source types (1GC138W)
Summary: Method entry breakpoints and source types (1GC138W)
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 2.0   Edit
Hardware: All Windows NT
: P3 enhancement (vote)
Target Milestone: 2.1   Edit
Assignee: Darin Wright CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 1554 1586 15248 15491 20507 (view as bug list)
Depends on:
Blocks:
 
Reported: 2001-10-10 22:15 EDT by Darin Swanson CLA
Modified: 2002-09-12 22:40 EDT (History)
6 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Swanson CLA 2001-10-10 22:15:15 EDT 
DS (4/11/2001 12:10:08 PM)
	Method entry breakpoints do not show in the breakpoints ruler for source types.
	Method entry breakpoints do not work for source types...the signatures are different
		e.g. ScopeTest#go(String)
					IMethod#getSignature --> (QString;)V
					Method#signature --> (Ljava/lang/String;)V

DS (4/11/2001 2:39:25 PM)
	Temp fix was to disable the action for methods that are not binary.

DW (4/16/01 1:53:54 PM)
	Could be re-enabled in future.
Comment 1 Darin Wright CLA 2001-10-29 10:42:45 EST 
*** Bug 1554 has been marked as a duplicate of this bug. ***
Comment 2 Darin Wright CLA 2002-01-15 12:27:52 EST 
note that breakpoint creation API needs to be revisited -> would like to set 
breakpoints in terms of type names, method signatures, rather than java model 
elements.
Comment 3 Darin Wright CLA 2002-02-26 12:53:20 EST 
Believe this is fixed.
Comment 4 Darin Wright CLA 2002-02-26 12:53:29 EST 
Please verify.
Comment 5 Darin Swanson CLA 2002-02-26 15:21:28 EST 
I have coded a prototype that "works" but I would propose that this feature not 
be considered for 2.0.

Reasons:
The implementation is/will be slow (Lots of String generation and manipulation)
Method breakpoints are slow already
Method exit/entry can be mimiced using line breakpoints.
Comment 6 Darin Wright CLA 2002-02-26 16:09:55 EST 
Deferred
Comment 7 Darin Wright CLA 2002-05-07 15:56:18 EDT 
*** Bug 15248 has been marked as a duplicate of this bug. ***
Comment 8 Darin Wright CLA 2002-05-07 22:45:31 EDT 
*** Bug 15491 has been marked as a duplicate of this bug. ***
Comment 9 Darin Wright CLA 2002-06-18 14:59:29 EDT 
*** Bug 20507 has been marked as a duplicate of this bug. ***
Comment 10 Jared Burns CLA 2002-06-25 15:04:54 EDT 
*** Bug 1586 has been marked as a duplicate of this bug. ***
Comment 11 Darin Swanson CLA 2002-06-26 11:16:44 EDT 
Resolving to later.
Comment 12 Darin Wright CLA 2002-07-30 14:38:31 EDT 
Propose to enable source method entry breakpoints with new (more efficient) 
implementation of entry breakpoints. See bug# 20869.
Comment 13 Darin Swanson CLA 2002-09-11 15:03:51 EDT 
Method breakpoints for source methods are now implemented.
Comment 14 Darin Swanson CLA 2002-09-11 15:12:03 EDT 
Darin W, please verify the changes to:
JavaModelListener
ManagerMethodBreakpointActionDelegate
MethodActionFilter
JavaMethodBreakpoint
Comment 15 Darin Wright CLA 2002-09-12 22:40:13 EDT 
Verified