Bug 155102 - Use ctrl+shift+G to find references of Extension points
Summary: Use ctrl+shift+G to find references of Extension points
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC All
: P3 enhancement (vote)
Target Milestone: 3.4 M3   Edit
Assignee: Ketan Padegaonkar CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday, contributed
Depends on:
Blocks:
 
Reported: 2006-08-24 15:34 EDT by Brian Bauman CLA
Modified: 2007-09-28 11:19 EDT (History)
4 users (show)

See Also:
caniszczyk: review? (caniszczyk)


Attachments
mylyn/context/zip (196.04 KB, application/octet-stream)
2007-09-22 08:00 EDT, Ketan Padegaonkar CLA
no flags Details
a patch for finding other references of an extension (6.01 KB, text/plain)
2007-09-22 08:10 EDT, Ketan Padegaonkar CLA
no flags Details
org.eclipse.pde.ui.patch (2.73 KB, patch)
2007-09-28 11:17 EDT, Chris Aniszczyk CLA
no flags Details | Diff
mylyn/context/zip (205.59 KB, application/octet-stream)
2007-09-28 11:17 EDT, Chris Aniszczyk CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Bauman CLA 2006-08-24 15:34:25 EDT
ctrl+shift+G is a java short cut to find references to a java object.  Currently, to find other references to an extension point, you have to click "find declaring extension point", then switch to the extension points tab, and click "Find references".  

It would be handy if I could find other references by using ctrl+shift+g, or even right click on an extension point to find other references.

I figured this might be up your alley Chris, under sexiness.
Comment 1 Chris Aniszczyk CLA 2006-08-24 21:20:35 EDT
sure, looks good to me
Comment 2 Ketan Padegaonkar CLA 2007-09-21 06:48:22 EDT
(In reply to comment #1)
> sure, looks good to me

I've been looking for this cool feature where you can right-click on an extension point and be able to see all places where the particular extension point is referenced.

I'd like to volunteer to fix this particular bug :)
Comment 3 Chris Aniszczyk CLA 2007-09-21 10:25:45 EDT
it's yours ;)
Comment 4 Chris Aniszczyk CLA 2007-09-21 11:03:29 EDT
btw, Ketan, this one will take a bit of work, let me know if you need a Mylyn context.

Comment 5 Wassim Melhem CLA 2007-09-21 11:22:28 EDT
Ketan, on the Extension points page of the plug-in editor, I believe you already have your dream function where you can search and find the corresponding extensions.
Comment 6 Ketan Padegaonkar CLA 2007-09-21 12:24:15 EDT
(In reply to comment #4)
> btw, Ketan, this one will take a bit of work, let me know if you need a Mylyn
> context.

Sure. Some context would be great :)
Comment 7 Ketan Padegaonkar CLA 2007-09-22 08:00:50 EDT
Created attachment 79025 [details]
mylyn/context/zip

Attaching context.
Comment 8 Ketan Padegaonkar CLA 2007-09-22 08:10:53 EDT
Created attachment 79026 [details]
a patch for finding other references of an extension

Currently works for IPluginExtension. Don't know if this should be made available for other types as well. See PluginSearchActionGroup#addFindOtherReferencesAction().

TODO:
 - Add a better icon than the existing one.
 - Mark as noteworthy ?
Comment 9 Brian Bauman CLA 2007-09-28 01:35:55 EDT
Hi Ketan, did you see the FindReferencesAction?  I think you might be able to add a bit of code to that class and not need to create a new class.  

This would also be more consistent with how we handle finding references of required plug-ins.  We take the import highlighted and find other imports.  Similarly, we can take the highlighted extension and find other extensions.
Comment 10 Brian Bauman CLA 2007-09-28 01:39:48 EDT
Let me apologize, it is late.  

First and most importantly, thank you very much for a working patch.  I like it.  It is very small and efficient.  Thank you very much for taking the time and fixing this bug!  We definitely appreciate it!
Comment 11 Chris Aniszczyk CLA 2007-09-28 11:17:33 EDT
Created attachment 79405 [details]
org.eclipse.pde.ui.patch

I simplified the patch a bit on the airplane a bit, used Ketan's patch for inspiration.

Thanks Ketan :)
Comment 12 Chris Aniszczyk CLA 2007-09-28 11:17:42 EDT
Created attachment 79406 [details]
mylyn/context/zip
Comment 13 Chris Aniszczyk CLA 2007-09-28 11:19:11 EDT
thanks again!