Community
Participate
Working Groups
When exporting a plug-in, it gets compiled through a process separate from the normal build process within the IDE. This build process (PDE.Build) disregards the text encoding used by the .java files and assumes some default setting. Since the correct text encoding of each file is known to the IDE, it should somehow be propagated to the PDE.Build process. The export can be made to work properly by redundantly specifying the text encoding in the build.properties file of each plugin, for example: javacDefaultEncoding.. = UTF-8 This is relatively acceptable in the simplest case when all the files use the same encoding, but anything beyond that would probably cause major problems.
I agree with the statement made by Marko. Moving to PDE UI in order to get the encodings written down in the build.properties.
What is the default value for pde.build (System.getProperties("file.encoding",...))? Should we only write the tag if the workspace is set to something other the default value for pde.build?
Brian, if no encoding is specified, the default encoding of the VM is used.
Note that in addition to the default encoding, encodings can also be set on a per file or per folder basis using something like javacCustomEncodings.. = src/org/foo[US-ASCII],\ src/org/foo/bar.java[ISO-8859-1]
*** Bug 81918 has been marked as a duplicate of this bug. ***
*** Bug 240449 has been marked as a duplicate of this bug. ***
I think we should do something about this issue finally.
The ".." at the end of the property didn't work for us. For anybody else trying to workaround, please see http://publib.boulder.ibm.com/infocenter/rsmhelp/v7r0m0/index.jsp?topic=/org.eclipse.pde.doc.user/reference/pde_feature_generating_build.htm for details of this build property. We had to put javacDefaultEncoding.ui.jar = UTF-8 for the library "ui.jar" that constitutes our plugin.
Yes, the actual format is "javacDefaultEncoding.<library>", '.' is just the most common library, it represents most bundles that are in jar shape.
Created attachment 121890 [details] org.eclipse.pde.core.patch Here's a stab at the problem. If your system encoding differents from your project specific encoding, we will prompty you with a warning and a quickfix. The only problem with this is that it doesn't help people with encoding that are file specific but I think the major problem we're trying to solve here is project level. I don't think it's common for people to just mark a few files with a special encoding. I could be wrong though.
I made some cosmetic changes but I'm content with this patch. > 20090107
*** Bug 176413 has been marked as a duplicate of this bug. ***
*** Bug 133584 has been marked as a duplicate of this bug. ***
(In reply to comment #10) > I don't think it's common for people to just mark a few files with a special encoding. I could be > wrong though. I think you might be. :) Please see bug 261395 openArchitectureWare discussion. I think a lot of users might want to use UTF for default but need ISO-8859-1 for say oAW. That would require a hopeless amount of configuration fiddling.
*** Bug 284107 has been marked as a duplicate of this bug. ***
I also think that this problem should be investigated further. Also the amount of duplicated bug reports seems to confirm I high interest for a further proceeding fix. To me it sounds like there are two viable options. Either we should make the pde plugin just honour the workbench file encoding settings or change the way that the JDT plugin is handling file encodings at all as e.g. have it also use a build.properties file the build process.
Re-opening this bug. I don't think it should be marked fixed as the fix appears to have been reverted due to bug 260997.
it's still in Eclipse 3.5.1
I wonder if it would be possible to automatically synchronize both? Right now I set the correct encoding in the IDE. Can't PDE Build just use the information from the ".settings/org.eclipse.core.resources.pref" file if it exists and amend those with the once specified in build.properties?
(In reply to comment #19) > I wonder if it would be possible to automatically synchronize both? Right now I > set the correct encoding in the IDE. Can't PDE Build just use the information > from the ".settings/org.eclipse.core.resources.pref" file if it exists and > amend those with the once specified in build.properties? Yes (sort of). The plan is to have PDE (IDE) update the build.properties with the correct information such that PDE build can honor it.
Created attachment 165625 [details] patch Enhancements to also report issues with custom encodings.
Created attachment 165674 [details] updated patch with HEAD
Created attachment 165764 [details] synch with head
Created attachment 165850 [details] head keeps changing.
Created attachment 165959 [details] patch NLS'd & improved messages.
Fixed. Note that JDT needs to fix bug 260997 before custom encodings are specified by any build.properties in the releng build.
*** Bug 261395 has been marked as a duplicate of this bug. ***
