Bug 153915 - can not tell if a Notation view is a label or compartment
Summary: can not tell if a Notation view is a label or compartment
Status: NEW
Alias: None
Product: GMF-Runtime
Classification: Modeling
Component: General (show other bugs)
Version: 1.0   Edit
Hardware: PC Windows XP
: P3 enhancement
Target Milestone: 2.1   Edit
Assignee: Anthony Hunter CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-08-15 10:42 EDT by Mohammed Mostafa CLA
Modified: 2010-07-19 12:28 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mohammed Mostafa CLA 2006-08-15 10:42:05 EDT
The fact that the Notation Views do not have a category attribue and they are too abstarct means we can not write generic code to hadle all labels or compartments on the diagram surface unless we write this code on the Edit Part level which is not possible in all cases, specially when the edit part are not there.
This could be solved by adding a kind attribute to the View, the kind will be an enumeration of Shape,Label,Compmartment ..
Comment 1 Anthony Hunter CLA 2007-06-27 15:44:05 EDT
Did we get this into the notational changes in 2.0?
Comment 2 Alex Boyko CLA 2007-06-28 10:26:25 EDT
I don't think so. This looks like a request for having Shape, Compartment and Label views in the metamodel. These views will simply implement interfaces common to shapes, labels and compartments. Is this correct, Mohammed?
Comment 3 Mohammed Mostafa CLA 2007-06-28 14:07:14 EDT
(In reply to comment #2)
> I don't think so. This looks like a request for having Shape, Compartment and
> Label views in the metamodel. These views will simply implement interfaces
> common to shapes, labels and compartments. Is this correct, Mohammed?

This issue can be handled by 2 solutions
1- introducing the a kind enumeration in the notation meta model, then introducing an attribute on the notation View for the kind where the enumeration will be used

2- The second solution whihc is the better solution and it will open the door for other good improvmenets in the fututre is to introduce subClasses of the Node class for Lables, Compartments and so one. The only thing with this approach is that it will be a file format change
Comment 4 Eclipse Webmaster CLA 2010-07-19 12:28:22 EDT
[GMF Restructure] Bug 319140 : product GMF and component
Runtime Diagram was the original product and component for this bug