Description Jeffrey Liu 2006-08-14 15:17:32 EDT

In J2EEFlexProjDeployable.members()...

IVirtualComponent vc = ComponentCore.createComponent(getProject());
if (vc != null) {
        IVirtualFolder vFolder = vc.getRootFolder();
        IModuleResource[] mr = getMembers(vFolder, Path.EMPTY);
        int size = mr.length;
        for (int j = 0; j < size; j++) {
                if (!members.contains(mr[j]))  // <------- check for existence
                        members.add(mr[j]);
        }
}

IContainer[] javaCont = getJavaOutputFolders();         
int size = javaCont.length;
for (int i = 0; i < size; i++) {
        IModuleResource[] mr = getMembers(javaCont[i], javaPath, javaPath,
javaCont);
        int size2 = mr.length;
        for (int j = 0; j < size2; j++) {
                if (!members.contains(mr[j]))  // <----- check for existence
                        members.add(mr[j]);
        }
}

Any reason why we must check for existence of an resource before adding it to
the member list? Do we expect the getMembers(...) methods to return duplicate
resources?

Reply from John:

With respect to the J2EEFlexProjDeployable, good question, I'm pretty sure the
getMembers() should not return duplicates because throughout the code we always
try and find the existing folder before adding a new folder.  So, those lines
may be candidates for removal.