Bug 152768 - [performance] The WS-I validator is reloading the same assertion document every time it validates a WSDL file
Summary: [performance] The WS-I validator is reloading the same assertion document eve...
Status: CLOSED FIXED
Alias: None
Product: WTP Webservices
Classification: WebTools
Component: wst.wsi (show other bugs)
Version: 1.5   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: 1.5.1 M151   Edit
Assignee: David Lauzon CLA
QA Contact: David Lauzon CLA
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2006-08-03 13:34 EDT by Jeffrey Liu CLA
Modified: 2006-09-27 09:07 EDT (History)
0 users

See Also:

Attachments
caches the profile assertions (5.64 KB, patch)
2006-08-09 17:25 EDT, David Lauzon CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeffrey Liu CLA 2006-08-03 13:34:13 EDT 
Build: WTP 1.5.1 0803

The following is a snippet of code from BasicProfileAnalyzer.validateConformance()

  ProfileAssertionsReader profileAssertionsReader =
    documentFactory.newProfileAssertionsReader();
  this.profileAssertions =
    profileAssertionsReader.readProfileAssertions(
      getAnalyzerConfig().getTestAssertionsDocumentLocation());

The issue here is that we do not need to re-create the profileAssertionsReader instance if the location of the assertion document is the same. The creation of the profileAssertionsReader is expensive because it has to read the entire WS-I assertion document from disk. We should cache the profileAssertionsReader whenever we can.
Comment 1 David Lauzon CLA 2006-08-09 17:25:56 EDT 
Created attachment 47653 [details]
caches the profile assertions
Comment 2 David Lauzon CLA 2006-08-09 17:27:44 EDT 
The patch caches the profile assertions and map them to the TAD's location.
Comment 3 Jeffrey Liu CLA 2006-09-21 14:23:43 EDT 
verified and close.
Comment 4 David Williams CLA 2006-09-27 09:07:55 EDT 
This is part of a "mass update" where bugs showing "fixed" between 7/1/2006 and 9/27/2006 are assumed fixed in WTP 1.5.1. feel free to change the target milestone if you know a more accurate setting.