Bug 152474 - ServiceReferenceImpl fails to find the PackageSource of a given service class
Summary: ServiceReferenceImpl fails to find the PackageSource of a given service class
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: Framework (show other bugs)
Version: 3.2   Edit
Hardware: All All
: P3 normal with 1 vote (vote)
Target Milestone: 3.2.1   Edit
Assignee: equinox.framework-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2006-08-01 12:06 EDT by Pavel Zuev CLA
Modified: 2006-08-23 15:20 EDT (History)
0 users

See Also:


Attachments
proposed patch (760 bytes, patch)
2006-08-01 12:22 EDT, Pavel Zuev CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Zuev CLA 2006-08-01 12:06:25 EDT
 
Comment 1 Pavel Zuev CLA 2006-08-01 12:13:03 EDT
(sorry, I've submitted the empty description accidentially)


The problem seems to be in the ServiceReferenceImpl.getPackageSource method, which fails to traverse interfaces implemented by the service class (probably due to a copy-pasted line of code).
Comment 2 Pavel Zuev CLA 2006-08-01 12:22:37 EDT
Created attachment 47154 [details]
proposed patch
Comment 3 BJ Hargrave CLA 2006-08-01 13:05:33 EDT
+1 for the patch.
Comment 4 Thomas Watson CLA 2006-08-02 17:35:04 EDT
This should be fixed for 3.2.1.
Comment 5 BJ Hargrave CLA 2006-08-02 20:06:45 EDT
I think you meant 3.2.1 :-)
Comment 6 Thomas Watson CLA 2006-08-03 11:16:12 EDT
[contributed patch applied]

definately 3.2.1 not 3.1.2 ;-)

I released the fix to 3.3 M1 (thanks Pavel).  Jeff, please approve fix for 3.2.1.  Thx.
Comment 7 Jeff McAffer CLA 2006-08-10 14:07:56 EDT
+1
Comment 8 Thomas Watson CLA 2006-08-10 14:30:50 EDT
Fixed in 3.2.1 maintenance release.
Comment 9 Thomas Watson CLA 2006-08-23 15:20:34 EDT
adding "contributed" keyword to patches contributed by the community.