Bug 152453 - Logic diagram shows RunAs DebugAs items in context menu
Summary: Logic diagram shows RunAs DebugAs items in context menu
Status: RESOLVED FIXED
Alias: None
Product: GMF-Runtime
Classification: Modeling
Component: General (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 major
Target Milestone: 1.0.1   Edit
Assignee: Syed Atif CLA
QA Contact: Tim deBoer CLA
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2006-08-01 09:42 EDT by Gleb Sturov CLA
Modified: 2010-07-19 12:25 EDT (History)
1 user (show)

See Also:


Attachments
Patch that removes invalid contributed items. (3.96 KB, patch)
2006-08-30 17:59 EDT, Syed Atif CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gleb Sturov CLA 2006-08-01 09:42:22 EDT
Logic diagram context menu shows items irrelevant to the diagram, such as 'Run As', 'Debug As', 'Profile As', etc.
Comment 1 Anthony Hunter CLA 2006-08-01 13:49:34 EDT
These Run On Server , Debug On Server show up on every popup. Do they come from WTP?
Comment 2 Tim deBoer CLA 2006-08-03 11:35:36 EDT
The Run As > menus come from the platform, and then the enablement/visibility of the various submenus (e.g. Run on Server) are based on the type of object that is selected. If you do not want Run As menu items to appear at all, then I think you need to make sure that the selection objects do not implement/adapt to ILaunchable from org.eclipse.core.debug.
Comment 3 Syed Atif CLA 2006-08-25 16:23:18 EDT
Wouldn't that remove the editor-based contributions? The trouble is not removing the entire Run/Debug menus but removing the Run on Server, debug on Server.

I am still curious as to why Run on Server/Debug on Server are contributed so broadly to all editors (they seem to be on the editor contribution actions list).
Comment 4 Anthony Hunter CLA 2006-08-28 17:06:40 EDT
The issue is a little bigger than just Run As / Debug As / Profile As

Other menu items are appearing:
Validate
Team -> Apply Patch.... (etc.)
Compare with ->
Replace With ->

These same menus appear on the shapes example in base GEF as well.
Comment 5 Syed Atif CLA 2006-08-30 17:59:44 EDT
Created attachment 49109 [details]
Patch that removes invalid contributed items.

This patch adds capability for clients to exclude items from their context menus ('filter'). By default, certain invalid entries have already been provided to be filtered (for example, 'Run as', 'Debug As', etc.)

Class affected:
1. org.eclipse.gmf.runtime.diagram.ui.providers.DiagramContextMenuProvider
Comment 6 Anthony Hunter CLA 2006-08-31 11:00:09 EDT
Committed the patch .
Comment 7 Eclipse Webmaster CLA 2010-07-19 12:25:57 EDT
[GMF Restructure] Bug 319140 : product GMF and component
Runtime Diagram was the original product and component for this bug