Community
Participate
Working Groups
Instead of automatically opening when first triggered, which is easy to miss, open a dialog that describes its role similar to how perspectives are triggered. Something like “You have just created an aspect, open the Cross References view in order to see the crosscutting structure of AspectJ Declarations”? It allows a yes/no choice, and offers the “do not show again” checkbox. The view is likely to be blank when first opened so stating its role will help.
Created attachment 50636 [details] not complete: need to add/change dialog messages
Created attachment 52835 [details] Complete fix (without test) for this behaviour You don't need the previous patch attached to this bug, as the code has been refactored in to this patch.
Created attachment 53366 [details] New fix and visual tests
With the above patch the dialog doesn't seem to trigger for me (although the visual test passes). Also, I think opening the AspectJ editor would be a better trigger point than creating an aspect, as the user may just be viewing existing code rather than creating a new aspect.
Created attachment 55398 [details] Default values added
The original bug description refers to aspect creation, not the opening of an aspect; this is why the trigger point is not the AspectJ editor. Also, the analagous perspective use case is based on opening the appropriate perspective "when creating a project", as per the the preferences dialog.
The xref view should be opened when it would be useful to the user to do so. As we can't read users' minds we have to go for the closest approximation. A new user's first encounter with an aspect is at least as likely to be viewing one someone else has written as writing one themselves. A trigger point of opening the AspectJ editor covers both cases instead of just creation. A suitable message would be something like "The Cross References view is associated with the AspectJ Editor. It shows the crosscutting structure of AspectJ declarations. Do you want to open this view now?". This also sounds much less like "You appear to be writing an aspect...", which is a good thing :)
Created attachment 56075 [details] Cumulative patch, incorporating latest requirements
OK, with the latest patch the dialog is triggered by opening the AspectJ editor and the message has been amended accordingly.
Patch applied - I think this can be closed now
Closing off, as per Matt's comments
