Bug 151402 - Grid spacing property text control is not not I18N compliant (decimal separator)
Summary: Grid spacing property text control is not not I18N compliant (decimal separator)
Status: RESOLVED FIXED
Alias: None
Product: GMF-Runtime
Classification: Modeling
Component: General (show other bugs)
Version: 1.0   Edit
Hardware: PC Windows XP
: P3 normal
Target Milestone: 1.0.1   Edit
Assignee: Tom Macdougall CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2006-07-21 09:27 EDT by Tom Macdougall CLA
Modified: 2010-07-19 12:27 EDT (History)
0 users

See Also:

Attachments
patch for ruler and grid property sheet grid spacing text input (2.11 KB, patch)
2006-07-21 09:33 EDT, Tom Macdougall CLA 		no flags Details | Diff
patch for Ruler grid spacing I18N (2.89 KB, patch)
2006-09-08 17:08 EDT, Tom Macdougall CLA 		no flags Details | Diff
patch for grid spacing conformance for different locales (2.95 KB, patch)
2006-09-11 14:56 EDT, Tom Macdougall CLA 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tom Macdougall CLA 2006-07-21 09:27:57 EDT 
With the OS set to the German locale under Regional Options (WinXP)

Create a GMF logic diagram
Open the properties view
The grid spacing should appear with the comma separator
Input 1,2 as a new value

Note the text control reverts to its previous value and does not accept the new value.
Comment 1 Tom Macdougall CLA 2006-07-21 09:33:05 EDT 
Created attachment 46631 [details]
patch for ruler and grid property sheet grid spacing text input

Used the number formatter on the input value instead of Double's doubleValue method. Note that the formatter will treat 1.2 as 12 in this type of locale.
Comment 2 Anthony Hunter CLA 2006-08-30 16:34:36 EDT 
Tom will get the patch reviewed.
Comment 3 Tom Macdougall CLA 2006-09-08 17:08:23 EDT 
Created attachment 49773 [details]
patch for Ruler grid spacing I18N

The workspace property value was not restored when an incorrect entry was processed. It was using the preferences value.
Comment 4 Tom Macdougall CLA 2006-09-11 14:56:10 EDT 
Created attachment 49868 [details]
patch for grid spacing conformance for different locales

Fixes problem when parsed input is the same as the previous value and the text value remains the unparsed value. Example: new value: "11a" and previous value: "11".
Comment 5 Linda Damus CLA 2006-09-11 15:39:42 EDT 
Reviewed and committed the patch.
Comment 6 Eclipse Webmaster CLA 2010-07-19 12:27:29 EDT 
[GMF Restructure] Bug 319140 : product GMF and component
Runtime Diagram was the original product and component for this bug