Bug 151112 - Organize Manifests adds .settings and META-INF to Export-Package
Summary: Organize Manifests adds .settings and META-INF to Export-Package
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3 M1   Edit
Assignee: Brian Bauman CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 148944
Blocks:
  Show dependency tree
 
Reported: 2006-07-19 13:33 EDT by Markus Keller CLA
Modified: 2006-07-21 22:04 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2006-07-19 13:33:30 EDT 
M20060712-0922 (3.2)

Organize Manifests adds .settings and META-INF to Export-Package.
To reproduce, apply action to org.junit4 R3_2.
Comment 1 Brian Bauman CLA 2006-07-20 15:39:48 EDT 
ok, fixed.  The problem was coming from the first checkbox in the organize manifest wizard.  This button adds all packages in your project to the export-package header.  Since the jar in the project is on the buildpath, the folders in it (.settings and META-INF) were added.  

The fix is to filter out META-INF as a special case while also not adding any folders who start with '.'.  

Modified org.eclipse.pde.internal.ui.wizards.tools.OrganizeManifest v 1.7.  Should be in 3.3 M1
Comment 2 Markus Keller CLA 2006-07-21 04:52:44 EDT 
D'oh, this is a bit complicated... .  There was a bug in jdt.core which made folders with invalid package names in jars appear as IPackageFragments. This has been fixed in HEAD (but the fix still a bit controversial).

With I20060718-0800, the tricks in PDE are not required any more, since those folders are no longer considered as packages.

Final solution depends on outcome of bug 148944. I'd suggest to revert the fix again for now. Sorry for the hassle, but I wasn't aware of that jdt.core problem.
Comment 3 Wassim Melhem CLA 2006-07-21 08:11:16 EDT 
Brian, I agree with Markus.  The fix in PDE did not look right to me.
Comment 4 Brian Bauman CLA 2006-07-21 11:13:53 EDT 
I guess I was on a roll fixing bugs and fixed something I shouldn't have :)
Comment 5 Wassim Melhem CLA 2006-07-21 22:04:08 EDT 
will close since we reverted the change.