Bug 150982 - Bookmark view not sync with diagram eidtor
Summary: Bookmark view not sync with diagram eidtor
Status: RESOLVED FIXED
Alias: None
Product: GMF-Runtime
Classification: Modeling
Component: General (show other bugs)
Version: 1.0   Edit
Hardware: PC Windows XP
: P3 major
Target Milestone: 1.0.1   Edit
Assignee: Syed Atif CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2006-07-18 13:36 EDT by Tim Kan CLA
Modified: 2010-07-19 12:26 EDT (History)
1 user (show)

See Also:

Attachments
Patch that keeps the bookmarks in sync. (8.38 KB, patch)
2006-07-27 15:11 EDT, Syed Atif CLA 		no flags Details | Diff
Updated patch (7.49 KB, patch)
2006-08-01 15:09 EDT, Syed Atif CLA 		no flags Details | Diff
Optimized patch. (10.03 KB, patch)
2006-08-08 11:37 EDT, Syed Atif CLA 		no flags Details | Diff
More optimizations. (10.32 KB, patch)
2006-08-08 17:23 EDT, Syed Atif CLA 		no flags Details | Diff
Structural reforms. (12.15 KB, patch)
2006-08-11 11:32 EDT, Syed Atif CLA 		no flags Details | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Kan CLA 2006-07-18 13:36:30 EDT 
Delete the "bookmark" decorated figure on diagram, but corresponding item is not removed in "Bookmark" view.
Comment 1 Syed Atif CLA 2006-07-27 15:11:21 EDT 
Created attachment 46902 [details]
Patch that keeps the bookmarks in sync.

This patch adds a RemoveBookmarksAdvice and RemoveBookmarkCommand that deletes the bookmark(s) (from the associated IFile). The advice is registered into the default context (so it works on geoshapes) but it has to be included into the logic example (provided in this patch). 

All clients need to bind this advice into their context if they want to keep their bookmarks in sync with the bookmark viewer.

Files affected:
1. +org.eclipse.gmf.runtime.diagram.core.edithelpers.RemoveBookmarksAdvice
2. +org.eclipse.gmf.runtime.diagram.core.commands.RemoveBookmarkCommand
3. plugin.xml in org.eclipse.gmf.runtime.diagram.core
3. plugin.xml in org.eclipse.gmf.examples.runtime.diagram.logic
Comment 2 Syed Atif CLA 2006-08-01 15:09:38 EDT 
Created attachment 47170 [details]
Updated patch

This patch reflects the changes made in Bug 151641.
Comment 3 Syed Atif CLA 2006-08-08 11:37:19 EDT 
Created attachment 47535 [details]
Optimized patch.

Updated patch with optimizations.
Comment 4 Syed Atif CLA 2006-08-08 17:23:36 EDT 
Created attachment 47574 [details]
More optimizations.
Comment 5 Syed Atif CLA 2006-08-11 11:32:22 EDT 
Created attachment 47773 [details]
Structural reforms.

Structural reformations to bring about even greater optimizations (courtesy: Linda) :)
Comment 6 Linda Damus CLA 2006-08-11 14:36:12 EDT 
Committed the patch.
Comment 7 Eclipse Webmaster CLA 2010-07-19 12:26:54 EDT 
[GMF Restructure] Bug 319140 : product GMF and component
Runtime Diagram was the original product and component for this bug