Bug 150867 - [performance] Server config dialog of the WS wizard leaks 4 images objects
Summary: [performance] Server config dialog of the WS wizard leaks 4 images objects
Status: CLOSED FIXED
Alias: None
Product: WTP Webservices
Classification: WebTools
Component: wst.ws (show other bugs)
Version: 1.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 1.5.1 M151   Edit
Assignee: Seng Phung Lu CLA
QA Contact: Chris Brealey CLA
URL:
Whiteboard:
Keywords: performance
Depends on: 150865
Blocks:
  Show dependency tree
 
Reported: 2006-07-17 16:41 EDT by Jeffrey Liu CLA
Modified: 2006-09-15 15:14 EDT (History)
0 users

See Also:

Attachments
consumption.ui plugin patch (6.93 KB, patch)
2006-07-26 14:38 EDT, Seng Phung Lu CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeffrey Liu CLA 2006-07-17 16:41:43 EDT 
Build: Callisto 3.2

After you launch the WS wizard, on the first page, if you click on the link that pops up the server config dialog, 4 images will be leaked. They are:

	at org.eclipse.swt.graphics.Device.new_Object(Device.java:753)
	at org.eclipse.swt.graphics.Image.<init>(Image.java:491)
	at org.eclipse.jface.resource.ImageDescriptor.createImage(ImageDescriptor.java:295)
	at org.eclipse.jface.resource.ImageDescriptor.createImage(ImageDescriptor.java:233)
	at org.eclipse.jface.resource.ImageDescriptor.createImage(ImageDescriptor.java:211)
	at org.eclipse.jst.ws.internal.consumption.ui.wizard.RuntimeServerSelectionDialog$ServersList.setExistingServersTree(RuntimeServerSelectionDialog.java:565)
	at org.eclipse.jst.ws.internal.consumption.ui.wizard.RuntimeServerSelectionDialog$ServersList.setServerTreeItems(RuntimeServerSelectionDialog.java:553)



	at org.eclipse.swt.graphics.Device.new_Object(Device.java:753)
	at org.eclipse.swt.graphics.Image.<init>(Image.java:491)
	at org.eclipse.jface.resource.ImageDescriptor.createImage(ImageDescriptor.java:295)
	at org.eclipse.jface.resource.ImageDescriptor.createImage(ImageDescriptor.java:233)
	at org.eclipse.jface.resource.ImageDescriptor.createImage(ImageDescriptor.java:211)
	at org.eclipse.jst.ws.internal.consumption.ui.wizard.RuntimeServerSelectionDialog$ServersList.setServerTypesTree(RuntimeServerSelectionDialog.java:592)
	at org.eclipse.jst.ws.internal.consumption.ui.wizard.RuntimeServerSelectionDialog$ServersList.setServerTreeItems(RuntimeServerSelectionDialog.java:554)



	at org.eclipse.swt.graphics.Device.new_Object(Device.java:753)
	at org.eclipse.swt.graphics.Image.<init>(Image.java:491)
	at org.eclipse.jface.resource.ImageDescriptor.createImage(ImageDescriptor.java:295)
	at org.eclipse.jface.resource.ImageDescriptor.createImage(ImageDescriptor.java:233)
	at org.eclipse.jface.resource.ImageDescriptor.createImage(ImageDescriptor.java:211)
	at org.eclipse.jst.ws.internal.consumption.ui.wizard.RuntimeServerSelectionDialog$ServersList.setExistingServersTree(RuntimeServerSelectionDialog.java:565)
	at org.eclipse.jst.ws.internal.consumption.ui.wizard.RuntimeServerSelectionDialog$ServersList.setServerTreeItems(RuntimeServerSelectionDialog.java:553)
	at org.eclipse.jst.ws.internal.consumption.ui.wizard.RuntimeServerSelectionDialog.createDialogArea(RuntimeServerSelectionDialog.java:260)





	at org.eclipse.swt.graphics.Device.new_Object(Device.java:753)
	at org.eclipse.swt.graphics.Image.<init>(Image.java:491)
	at org.eclipse.jface.resource.ImageDescriptor.createImage(ImageDescriptor.java:295)
	at org.eclipse.jface.resource.ImageDescriptor.createImage(ImageDescriptor.java:233)
	at org.eclipse.jface.resource.ImageDescriptor.createImage(ImageDescriptor.java:211)
	at org.eclipse.jst.ws.internal.consumption.ui.wizard.RuntimeServerSelectionDialog$ServersList.setServerTypesTree(RuntimeServerSelectionDialog.java:592)
	at org.eclipse.jst.ws.internal.consumption.ui.wizard.RuntimeServerSelectionDialog$ServersList.setServerTreeItems(RuntimeServerSelectionDialog.java:554)
	at org.eclipse.jst.ws.internal.consumption.ui.wizard.RuntimeServerSelectionDialog.createDialogArea(RuntimeServerSelectionDialog.java:260)
Comment 1 Jeffrey Liu CLA 2006-07-17 16:42:12 EDT 
Should be easy enough to fix in 1.5.1
Comment 2 Chris Brealey CLA 2006-07-17 22:50:47 EDT 
Seng, would you please handle? Thanks - CB.
Comment 3 Seng Phung Lu CLA 2006-07-26 14:38:07 EDT 
Created attachment 46835 [details]
consumption.ui plugin patch

NOTE: This patch adds on to a previous fix for 150865.
Comment 4 Seng Phung Lu CLA 2006-07-26 14:38:50 EDT 
Peter, ready to be picked up. This bug modifies the same file as a previous patch for 150865.  You should be able to 'merge' or overwrite the two locally before committing.

Basically, the fix just disposes the image objects on "Ok/Cancel" pressed.  I ran sleak to verify it is no longer leaking.
Comment 5 Kathy Chan CLA 2006-07-26 20:47:05 EDT 
Released to HEAD and R1_5_maintenance as v200607270039.  This will be in the 07/28 WTP 1.5.1 M-build.
Comment 6 Jeffrey Liu CLA 2006-09-14 15:45:06 EDT 
Verified.
Comment 7 Jeffrey Liu CLA 2006-09-14 15:45:14 EDT 
Close.
Comment 8 Chris Brealey CLA 2006-09-15 15:14:54 EDT 
Closed.