Community
Participate
Working Groups
Build: WTP 1.5.0 In the org.eclipse.jst.j2ee.ejb.annotations.internal.xdoclet.facet.XDocletFacetInstallDelegate class, the execute(...) method, we are doing a FULL_BUILD in the UI thread. This may hang the UI for a few seconds depending on the size of your project. Two questions pop up: 1. Why are we doing a full build? Wouldn't auto build take care of things? 2. If the full build is needed, can we move it to a job?
Rising severity to critical, priority to P2 and setting target to 1.5.1 since this is a hot performance issue.
The build of the XDoclet facet was moved to the wizard UI thread as a workaround during EJB/Servlet creation to force a build. The problem was although a build request was registered it was being discarded. We will revisit the problem
*** Bug 150644 has been marked as a duplicate of this bug. ***
Hi Naci, do you mean if you run the build in a Job, the build or the Job is somehow being discarded? If so, that sounds like an Eclipse bug. I'll investigate. Also, is a full build on the project really necessary? Can't we just do a build with the XDoclet builder and follow by a build from the Java compiler. Is that sufficient?
Jeff, I am not sure if it is an eclipse bug, or smt wrong with the way we start a build (more likely) but I already spent two days chasing it in the guts of eclipse threads and jbos - nothing to envy - But the only thing I can replicate is tha: -Create first EJB - build works as expcted. -Create a few more EJBS ,in sequence - and it starts loosing the build job during the creation. - Modify the EJB in code, builder always works as expected. My suspicion is that after Java builder completes its job, xdoclet builder is dropped. More investigating to do
Hi Naci, here're my observations... - During the creation of the first EJB, the XDocletFacetInstallDelegate is invoked. As a result, this triggers a build, causing the XDoclet builder to run and then the Java builder to run. However, later on in the code, the XDocletBuildUtility is invoked, which triggers the XDoclet builder to run only. - On subsequence EJB creations, the XDocletFacetInstallDelegate is not invoked. Therefore, no build will be registered. Then XDocletBuildUtility is invoked and causing the XDoclet builder to run. Since no build was registered, the Java builder did not run and the generated Java code was not compiled. If my understanding is correct, then here's what we need to do: 1. Remove the build from XDocletFacetInstallDelegate. 2. Either register a build at the end of XDocletBuilder's build(...) method, or in XDocletBuildUtility, register a build right after XDocletBuilder is invoked.
Created attachment 46529 [details] Patch for ejb.annotation.xdoclet This patch seems to fix the problem. Naci, can you review it?
I've got an adopter to help verify the patch. The adopter indicated that the patch fixed the problem.
Jeff, testing a few cases myself. I will release the patch for next week's M.
Fixed in M1.51 and R2.0 streams
*** Bug 152559 has been marked as a duplicate of this bug. ***
In trying to validate this fix for duped bug #152559 with using 3_2-M20060802_WTP_1.5.1-200608241726 the problem still persists. The UI is hung the whole time while the Right click -> Run XDoclet action is being performed. When the UI wakes up again the Console output jumps to displaying the completed XDoclet task output. When removing and readding a project facet for XDoclet support I dont see any visible sign XDoclet was run (no console output) and there is no UI hang.
Daryl, You are correct. This fix did not help the action. I wrapped the RunXDoclet action in a user Job object so that it can be put in the background.
Are additional fixes already in the pipeline towards validating bug #152559 ? My own understanding of this bug here, there was a UI hang when adding the XDoclet facet to a project. However with my own testing it does not appear XDoclet runs anymore when being added, is this by design or just unreported so far. 3_2-M20060802_WTP_1.5.1-200608241726 Does Jeffrey agree this bug resolved ? Naci are you saying this bug (and its fix) should resolve the regression in the right click action causing UI hang ?
I verify that this fixed the "hang" when we create an XDoclet EJB. However, I have not verify this fix against the Run XDoclet action "hang" outlined in bug 152559. That sounds like a separate issue.
Hi Daryl, There are additional fixes for the UI hanging during the XDoclet action, these are already commited to te 1.5.1 stream, you can use tha latest build from the committers page or wait for this week's M-Build to verify. Basically, the fix solves your problem by putting the build in a Job, and when the XDoclet action is run a JOB dialog pops up, and if ytou want to continues without waiting for the job to finish, you can click the "Run in the backgorund" button.
Closing.
