Bug 150018 - east and north side border items overlap; can cause infinite loop / crash
Summary: east and north side border items overlap; can cause infinite loop / crash
Status: RESOLVED FIXED
Alias: None
Product: GMF-Runtime
Classification: Modeling
Component: General (show other bugs)
Version: 1.0   Edit
Hardware: All All
: P3 normal
Target Milestone: 1.0.1   Edit
Assignee: Cherie Revells CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2006-07-07 13:54 EDT by Jennifer Cormier CLA
Modified: 2010-07-19 12:27 EDT (History)
1 user (show)

See Also:

Attachments
BorderItemLocator.java - patch (804 bytes, patch)
2006-07-07 13:56 EDT, Jennifer Cormier CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jennifer Cormier CLA 2006-07-07 13:54:25 EDT 
When a border item has EAST as its preferred side, if there is another border item already there it is supposed to move UP and then if it runs out of space then to the NORTH side.

However, there is a typo and instead of moving up border items move down, but only slightly and they overlap.

And if the new border item bound's height is equal to the vertical_gap, then it gets in an infinite loop because the recommendedLocation.y never changes.

A similar problem exists on the NORTH side and it also can cause a crash.
Comment 1 Jennifer Cormier CLA 2006-07-07 13:56:33 EDT 
Created attachment 45941 [details]
BorderItemLocator.java - patch
Comment 2 Cherie Revells CLA 2006-09-06 11:37:12 EDT 
Committed the patch.  

This will slightly change where new border items are placed when multiple border items overlap -- they will now be spaced correctly on the north and east side as they were on the south and west side.
Comment 3 Eclipse Webmaster CLA 2010-07-19 12:27:18 EDT 
[GMF Restructure] Bug 319140 : product GMF and component
Runtime Diagram was the original product and component for this bug