Bug 14952 - Diff Browser Opens Too Small / Not Easily Resizable
Summary: Diff Browser Opens Too Small / Not Easily Resizable
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: 2.0 F3   Edit
Assignee: Andre Weinand CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-04-30 15:17 EDT by Dave Ings CLA
Modified: 2002-06-13 04:44 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Ings CLA 2002-04-30 15:17:01 EDT
Opened after discussion with Jin Li (UCD Toronto). Observed on V1 & V2 M5.

The Eclipse diff browser (the one you get from replace from local, synchronize, 
refactoring, etc.) IMHO should be improved as follows:

It always comes up too small to be usable. I'm always relocating it followed by 
enlarging it. (It seems to be defaulting to 50% of the screen real estate).

Worse, it neither remembers the resizing in subsequent invocations nor can you 
double click on the title bar to maximize it (which would keep me from 
complaining). Given the number of times this dialog is raised during routine 
development, I think it is a major PITA / productivity hit.

I would recommend:

(Easy fix) Maximize via double clicking on title bar.
(Better fix). Remember size and position for subsequent invocations.

Dave Ings
ings@ca.ibm.com
Comment 1 Andre Weinand CLA 2002-05-16 11:48:58 EDT
Fixed for 20020517:
- location and size for Compare/Replace/Add dialogs is made persistent
- Refactoring wizard remembers only size
Comment 2 Dave Ings CLA 2002-06-06 11:51:27 EDT
Close (thanks) but no cigar yet (on F2).

With Compare/Replace/Add the dialog is only persisted if you hit the system 
close X (or Alt-F4). It is not persisted if you press OK / Replace / Cancel / 
Restore. You have to specifically open the dialog, resize it, and then close it 
without doing any work. This is unconventional UI behaviour, it took a while to 
figure out, I actually thought at first the improvement hadn't made it into F2.

With Refactoring, pressing Finish will persist the dialog, but pressing cancel 
will not. IMHO this isn't as serious, but may still confuse the user.
Comment 3 Andre Weinand CLA 2002-06-06 12:52:09 EDT
Changed behavior in SWT since fix was done: dismissing a Dialog with OK and 
Cancel no longer triggers a call to the Shell's shellClosed handler (where I 
would save the changed bounds).

Fixed for 20020607 but net yet released.
(BTW I'm saving the bounds even on Cancel).

Needs aproval.
Comment 4 Andre Weinand CLA 2002-06-07 07:16:50 EDT
fixed reviewed by Dirk Baeumer.
and released for 20020607
Comment 5 Dani Megert CLA 2002-06-13 04:44:38 EDT
Verified against F3.
Dialogs are OK. Synchronize uses a view.