Bug 149154 - BinaryMethod#getParameterNames() should not try to extract from attached javadoc for synthetics
Summary: BinaryMethod#getParameterNames() should not try to extract from attached java...
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3 M6   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-06-29 09:41 EDT by Markus Keller CLA
Modified: 2007-03-20 13:13 EDT (History)
0 users

See Also:

Attachments
Proposed fix (1.57 KB, patch)
2007-02-13 21:45 EST, Olivier Thomann CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2006-06-29 09:41:30 EDT 
HEAD

BinaryMethod#getParameterNames() should not try to extract names from attached javadoc for synthetic methods. By construction, synthetic methods have no javadoc.

An exception could be bridge methods, which could use the parameter names of their original method. But I think even there, generated parameter names make it more clear that those methods are compiler-generated.

Steps to reproduce:
- run HEAD with a VM that makes your firewall show an alert when accessing untrusted internet servers
- open java.util.Collections from an 1.5 rt.jar
- in the Outline view, select access$000(Object, Object)
Comment 1 Olivier Thomann CLA 2007-02-13 21:45:46 EST 
Created attachment 58935 [details]
Proposed fix
Comment 2 Olivier Thomann CLA 2007-02-14 09:58:02 EST 
Added regression test org.eclipse.jdt.core.tests.model.AttachedJavadocTests#test022. This test ensures that the parameter names are arg0 and arg1, but it cannot check if there is a connection to the javadoc.
This needs to be tested manually following steps described in comment 0.
Released for 3.3M6.
Comment 3 David Audel CLA 2007-03-20 13:13:22 EDT 
Verified for 3.3 M6 using build I20070320-0010