Community
Participate
Working Groups
PAGE_UP and DOWN have unpredictable behavior that doesn't really help the user any. HOME and END throw exceptions when nothing is selected. java.lang.NullPointerException at org.eclipse.gmf.runtime.diagram.ui.internal.parts.DiagramGraphicalViewerKeyHandler.getPartNavigationSiblings(DiagramGraphicalViewerKeyHandler.java:123) at org.eclipse.gmf.runtime.diagram.ui.internal.parts.DiagramGraphicalViewerKeyHandler.navigateEndSibling(DiagramGraphicalViewerKeyHandler.java:215) at org.eclipse.gmf.runtime.diagram.ui.internal.parts.DiagramGraphicalViewerKeyHandler.keyPressed(DiagramGraphicalViewerKeyHandler.java:69) at org.eclipse.gef.KeyHandler.keyPressed(KeyHandler.java:54) at org.eclipse.gmf.runtime.diagram.ui.internal.parts.DirectEditKeyHandler.keyPressed(DirectEditKeyHandler.java:89) at org.eclipse.gef.tools.SelectionTool.handleKeyDown(SelectionTool.java:319) at org.eclipse.gef.tools.AbstractTool.keyDown(AbstractTool.java:901) at org.eclipse.gef.tools.SelectionTool.keyDown(SelectionTool.java:468) at org.eclipse.gef.EditDomain.keyDown(EditDomain.java:153) at org.eclipse.gef.ui.parts.DomainEventDispatcher.dispatchKeyPressed(DomainEventDispatcher.java:246) at org.eclipse.draw2d.LightweightSystem$EventHandler.keyPressed(LightweightSystem.java:488) at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:122) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:66) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:928) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:952) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:937) at org.eclipse.swt.widgets.Widget.sendKeyEvent(Widget.java:965) at org.eclipse.swt.widgets.Widget.sendKeyEvent(Widget.java:961) at org.eclipse.swt.widgets.Widget.wmKeyDown(Widget.java:1560) at org.eclipse.swt.widgets.Control.WM_KEYDOWN(Control.java:3567) at org.eclipse.swt.widgets.Control.windowProc(Control.java:3275) at org.eclipse.swt.widgets.Display.windowProc(Display.java:4025) at org.eclipse.swt.internal.win32.OS.DispatchMessageW(Native Method) at org.eclipse.swt.internal.win32.OS.DispatchMessage(OS.java:1923) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:2966) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:1914) at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:1878) at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:419) at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149) at org.eclipse.ui.internal.ide.IDEApplication.run(IDEApplication.java:95) at org.eclipse.core.internal.runtime.PlatformActivator$1.run(PlatformActivator.java:78) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:92) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:68) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:400) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:177) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:585) at org.eclipse.core.launcher.Main.invokeFramework(Main.java:336) at org.eclipse.core.launcher.Main.basicRun(Main.java:280) at org.eclipse.core.launcher.Main.run(Main.java:977) at org.eclipse.core.launcher.Main.main(Main.java:952)
Created attachment 46459 [details] Patch that fixes the null poiner bug and correctly implements the PAGE_UP/PAGE_DOWN behavior.
with the patch, HOME and END does not throw the exceptions any more but page up and down still have unpredictable behavior
Created attachment 49002 [details] Patch that fixes the NPE only This patch does not attempt to implement PAGE UP/PAGE DOWN behavior, instead just fixes the NPE. PAGE UP/PAGE DOWN has yet to be implemented in GEF.
Created attachment 49726 [details] Updated NPE patch that does not depend on DiagramEditPart and DiagramRootEditPart
Created attachment 49731 [details] Minor changes
Committed the patch to avoid the NPEs.
[GMF Restructure] Bug 319140 : product GMF and component Runtime Diagram was the original product and component for this bug
