Bug 148836 - Create "Create generator model..." wizard instead of existing dialog
Summary: Create "Create generator model..." wizard instead of existing dialog
Status: RESOLVED FIXED
Alias: None
Product: GMF-Tooling (ARCHIVED)
Classification: Modeling
Component: Core (show other bugs)
Version: 1.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 2.0   Edit
Assignee: Alexander Fedorov CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2006-06-27 11:44 EDT by Alex Shatalin CLA
Modified: 2010-07-19 12:16 EDT (History)
1 user (show)

See Also:

Attachments
wizard implementation (112.25 KB, patch)
2007-01-11 12:18 EST, Alexander Fedorov CLA 		no flags Details | Diff
Revised implementation (110.68 KB, patch)
2007-01-17 10:58 EST, Alexander Fedorov CLA 		no flags Details | Diff
Revised implementation 2 (96.49 KB, patch)
2007-01-18 11:45 EST, Alexander Fedorov CLA 		no flags Details | Diff
NPE for design-only mapping fixed (6.30 KB, patch)
2007-01-25 12:12 EST, Alexander Fedorov CLA 		no flags Details | Diff
NPE for design-only mapping fixed (6.30 KB, patch)
2007-01-25 12:12 EST, Alexander Fedorov CLA 		no flags Details | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Shatalin CLA 2006-06-27 11:44:28 EDT 
- From the .gmfmap file popup menu invoke "Create generator model..." action -> Dialog asking for target file name appear. 
- Choose target model file name and press OK -> Generator Model Options dialog appear if org.eclipse.gmf.codegen.lite plugin present in this installation.

One wizard should be created instead of these two dialogs. First page of the wizard should be standard WizardNewFileCreationPage. Second page should be optional (present only if org.eclipse.gmf.codegen.lite plugin installed) and should contains only one checkbox: "Utilize enhanced features of GMF runtime". Another checkbox currently present in Generator Model Options dialog ("Use IMapMode") should be removed because the value of this checkbox could be predicted automatically - we should always use IMapMode if runtime library will be used in generated code and should not use it in the opposite situation.
Comment 1 Artem Tikhomirov CLA 2006-09-11 06:03:08 EDT 
Version/Milestone updated
Comment 2 Richard Gronback CLA 2006-11-13 10:34:49 EST 
Updated component and summary.
Comment 3 Alexander Fedorov CLA 2007-01-11 12:18:54 EST 
Created attachment 56787 [details]
wizard implementation

"Create generator model" wizard implementation
Comment 4 Alexander Fedorov CLA 2007-01-17 10:58:18 EST 
Created attachment 57018 [details]
Revised implementation

UI simplification, i18n clean up
Comment 5 Alexander Fedorov CLA 2007-01-18 11:45:12 EST 
Created attachment 57091 [details]
Revised implementation 2

Do not extend genarated GMFGen wizard
Comment 6 Artem Tikhomirov CLA 2007-01-24 12:49:30 EST 
For design-only mappings (i.e. no domain model at all):

java.lang.NullPointerException
	at org.eclipse.gmf.internal.bridge.transform.GenModelConfigurationPage.findGenmodel(GenModelConfigurationPage.java:123)
	at org.eclipse.gmf.internal.bridge.transform.GenModelConfigurationPage.initControls(GenModelConfigurationPage.java:114)
	at org.eclipse.gmf.internal.common.ui.ModelSelectionPage.setVisible(ModelSelectionPage.java:372)
	at org.eclipse.jface.wizard.WizardDialog.updateForPage(WizardDialog.java:1096)
Comment 7 Alexander Fedorov CLA 2007-01-25 12:12:36 EST 
Created attachment 57529 [details]
NPE for design-only mapping fixed

"Select GenModel" page will not be shown for Mapping without domain model
Comment 8 Alexander Fedorov CLA 2007-01-25 12:12:52 EST 
Created attachment 57530 [details]
NPE for design-only mapping fixed

"Select GenModel" page will not be shown for Mapping without domain model
Comment 9 Artem Tikhomirov CLA 2007-01-25 12:33:06 EST 
Comment on attachment 57530 [details]
NPE for design-only mapping fixed

Duplicated patch
Comment 10 Artem Tikhomirov CLA 2007-01-25 14:03:34 EST 
reviewed and committed
Comment 11 Eclipse Webmaster CLA 2010-07-19 12:16:22 EDT 
[GMF Restructure] Bug 319140 : product GMF and component
UI - Wizards was the original product and component for this bug