Bug 14860 - Folder generation aborts after one folder is skipped
Summary: Folder generation aborts after one folder is skipped
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows 2000
: P1 normal (vote)
Target Milestone: ---   Edit
Assignee: Dejan Glozic CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-04-29 13:07 EDT by Wassim Melhem CLA
Modified: 2002-04-29 15:53 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wassim Melhem CLA 2002-04-29 13:07:39 EDT 
Class: org.eclipse.pde.ui.templates.AbstractTemplateSection.java,
Method: generateFiles(File,IContainer,boolean,boolean,IProgressMonitor)

The for-loop goes through all the directories and files and copies a subset 
that is chosen by the subclass of AbstractTemplateSection.
However, in this code, the method erroneously returns as soon as one folder has 
been skipped.  Instead, we should process its siblings, if any.
The following if-statement should be changed from:
	if (isOkToCreateFolder(member) == false)
	    return;

to 
        if (isOkToCreateFolder(member) == false)
            continue;
Comment 1 Dejan Glozic CLA 2002-04-29 15:53:24 EDT 
Fixed.