Community
Participate
Working Groups
When opening the properties page on a java launch, process, thread or stack frame you only get the standard process properties page. Would be nice to get the VM Capabilities page as well. Should be possible using an enablement expression.
Created attachment 45199 [details] patch By setting objectClass=IAdaptable in property page definition (plugin.xml), the properties menu item appears for all adaptable objects resulting in a no properties for . error message if you try to view the properties of a launch. The objectClass attribute should not be necessary and is deprecated according to the doc, but it can't be removed do to bug 148241. Also the VM capabilities page should present a nice error message when the target is terminated. With this patch it just barfs out the standard "vm does not allow access" message which in this case is a lie. This error message is also presented to the user when they ask for the properties of the Process. I have not investigated why that happens yet.
Created attachment 45202 [details] patch fixes the error message for terminated VMs. Displays the vm capabilities when the process is selected. Need to resolve the objectClass issue still. This patch contributes the property page to all adaptable objects in any view in the workbench. If there are no property pages for that view the user will get an ugly error message when they select the Properties... menu item. The menu item is enabled because the selection applies (IAdaptable is selected) but there are no property pages because the enablement expression says that the vm capabilities page doesn't apply. (ie objectClass and enablesWhen don't play well together)
fixed in HEAD with changes to allow the page to be shown for all elements with a JDIDebugTarget, as well as the process for the launch. The solution for now is to have two property pages declared in the plugin.xml: one for IDebugTarget and the other for IProcess. Then once the objectClass issue is resolved we can remove one of the declaraitons and simply use the enabledWhen property tester to determine visibility of the properties page. Also made changes to when the page will show: if the target is disconnected or terminated the property page is not available, in favour of showing the page with an error message.
Created attachment 45507 [details] patch Still a problem with launch. The menu thinks that a property page is available when there isn't. This causes an ugly error dialog.
Tod, we're trying to create a property page that is enabled solely by an expression, ie: if we can get a Java Debug Target adapter from the current selection we want to show the VM capabilities for that target. When the selection in the debug view is the launch, we cannot get a target and no other property pages are contributed to launches. As a result the Properties... menu item is enabled, but selecting opens an error dialog. Is there a way to avoid this? It seems that the action should just be disabled if there are no property pages.
Not yet - but that is a seperate issue that is worth looking at. If you log me another bug I'll have a look at it for you. If you wanted to play around yourself have a look at PropertyDialogAction and see what you think needs to be done.
The problem is in PropertyDialogAction#isApplicableForSelection, which further calls hasPropertyPagesFor, which will return true if the property page manager has contributed pages for the specified type in the plugin declaration. This does not work if we choose to determine the availability of the page using an enabledWhen expression: the manager will say it has a page for that contribution, but we are explicitly saying not to provide it based on our enabledWhen expression. One of the two aforementioned methods needs to also consider enabledWhen expressions to determine if the object contribution is valid.
fixed in HEAD see LaunchView also updated read only labels in the breakpoint property pages see JavaBreakpointPage and JavaLineBreakpointChangePage
please verify Curtis
Verified in Windows XP and Linux
