Bug 147664 - Focus not set by adding a schema element/attribute
Summary: Focus not set by adding a schema element/attribute
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: 3.3 RC1   Edit
Assignee: Noam Chitayat CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2006-06-18 10:48 EDT by Nicole Schumacher CLA
Modified: 2007-06-05 18:18 EDT (History)
2 users (show)

See Also:

Attachments
Patch for bug 147664. (Affects SchemaElementDetails.java and SchemaAttributeDetails.java) (2.94 KB, patch)
2007-05-09 15:19 EDT, Noam Chitayat CLA 		wassim.melhem: review+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole Schumacher CLA 2006-06-18 10:48:52 EDT 
In the schema definition, add an element or an attribute. It would be good the focus is on the textbox "name" now.

Version: 3.2 RC7
Comment 1 Wassim Melhem CLA 2007-05-08 23:59:25 EDT 
Nice polish defect.  Just set the focus on the first text field.
Comment 2 Noam Chitayat CLA 2007-05-09 15:19:16 EDT 
Created attachment 66538 [details]
Patch for bug 147664. (Affects SchemaElementDetails.java and SchemaAttributeDetails.java)

When an attribute or an element is inserted, the relevant Details section's name field will grab focus (and move the cursor to the end of the current name).
Comment 3 Mike Pawlowski CLA 2007-05-09 18:53:38 EDT 
I'll review the patch
Comment 4 Wassim Melhem CLA 2007-05-09 23:40:10 EDT 
Comment on attachment 66538 [details]
Patch for bug 147664. (Affects SchemaElementDetails.java and SchemaAttributeDetails.java)

The name we generate is a placeholder anyway, so putting the cursor in the beginning or at the end is probably equally useful; but putting it at the end may be a bit controversial as it sets a precedent.

Released the patch without the moving of the cursor. 

Thanks Noam.
Comment 5 Wassim Melhem CLA 2007-05-09 23:40:44 EDT 
closing.  let's keep the train moving.