Bug 147497 - [Properties] Buttons on the appearance tab should be DROP_DOWN style
Summary: [Properties] Buttons on the appearance tab should be DROP_DOWN style
Status: RESOLVED FIXED
Alias: None
Product: GMF-Runtime
Classification: Modeling
Component: General (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 minor
Target Milestone: 2.1   Edit
Assignee: Carson Li CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed, usability
Depends on:
Blocks:
 
Reported: 2006-06-16 14:32 EDT by Randy Hudson CLA
Modified: 2010-07-19 21:59 EDT (History)
1 user (show)

See Also:

Attachments
Proposed Patch (16.25 KB, text/plain)
2007-11-20 16:33 EST, Carson Li CLA 		no flags Details
Before screenshot of the appearance tab. (4.53 KB, image/png)
2008-04-16 23:36 EDT, Anthony Hunter CLA 		no flags Details
After screenshot of the appearance tab. (3.80 KB, image/png)
2008-04-16 23:37 EDT, Anthony Hunter CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Randy Hudson CLA 2006-06-16 14:32:00 EDT 
In the properties view, Appearance tab, there are buttons for Font color, Foreground, and background color. For both accessibility and general usability, these buttons should have the SWT.DROP_DOWN style to indicate that clicking on them drops down another window. The style should also mean that a downward triangle is added to the widget.
Comment 1 Anthony Hunter CLA 2007-06-19 11:43:50 EDT 
Moving to the next release, GMF 2.1.
Comment 2 Carson Li CLA 2007-10-10 10:38:02 EDT 
after a bit of investigation, it seems that the problem arises from how the button in general is being created.  what was asked was for the SWT.DROP.DOWN style but that is currently not supported by the API, at least in the way to achieve the desired look of an icon being attached to a drop down bar, resulting in a new menu.  

What can achieve this is any of the color buttons on the eclipse tool bar.  However, those are created through plug-in extension points, unlike the BUTTON object.
Comment 3 Anthony Hunter CLA 2007-10-10 10:57:10 EDT 
We could look at putting a ToolBar in the section. If we add the SWT.FLAT style we would not see the borders on the toolbar. 

You can check out the SWT Controls example to see what controls are available.
Comment 4 Carson Li CLA 2007-11-20 16:33:42 EST 
Created attachment 83362 [details]
Proposed Patch

changed the bold button, italic button, fontcolor button, fillcolor button, linecolor button in ColorsAndFontsPropertySection into tool items
the "color" associated buttons now have clear SWT.DROP_DOWN styles. same goes for the gridline color button in RulerGridPropertySection.

the main "changecolor" method was duplicated because the initial method was protected and required a button.  the new method was simply modified to accept a tool item.
Comment 5 Anthony Hunter CLA 2007-12-06 16:19:29 EST 
Committed to head
Comment 6 Anthony Hunter CLA 2008-04-16 23:36:16 EDT 
Created attachment 96375 [details]
Before screenshot of the appearance tab.
Comment 7 Anthony Hunter CLA 2008-04-16 23:37:58 EDT 
Created attachment 96376 [details]
After screenshot of the appearance tab.

I do not think we are happy with this change we made a while back.

Although the buttons are now drop downs, the buttons have no borders. We should revert this change back.
Comment 8 Anthony Hunter CLA 2008-04-16 23:39:32 EDT 
Reopening
Comment 9 Anthony Hunter CLA 2008-04-18 17:32:29 EDT 
Rolled back the patch, we are using buttons again (before screenshot).
Comment 10 Richard Gronback CLA 2008-08-13 13:09:25 EDT 
[target cleanup] 2.1 M7 was the original target milestone for this bug
Comment 11 Eclipse Webmaster CLA 2010-07-19 21:59:54 EDT 
[GMF Restructure] Bug 319140 : product GMF and component
Runtime was the original product and component for this bug