Community
Participate
Working Groups
Using Eclipse 3.2 RC7 An extra, or dangling, comma in the Import-Package header does not result in an error being reported by the manifest editor. The Dependencies page of the form-based editor shows no imported packages whatsoever. It seems that this would be a nice piece of validation to support. This is an example of an illegal Import-Package header due to the dangling comma: Import-Package: com.foo, com.bar, And this is an example of an illegal Import-Package header due to the extra comma: Import-Package: com.foo,, com.bar By comparison, the same problem in the Export-Package header results in the error message "'Export-Package' has invalid format". Interestingly, when you try and launch Equinox with a bundle with an illegal manifest the "Validate Plug-in Set" button does identify and report the problem.
It seems that a missing comma is also not reported as an error. The problem is reported by the "Validate Plug-in Set" button from the launch configuration dialog. This is an example of an illegal Import-Package header due to a missing comma: Import-Package: com.foo com.bar
Another interesting one Adam, shouldn't be that bad.
my dream of having a bug open by one "Archer" and closed by another "Archer" have been dashed. Marking this one for bug day ;)
I tried this in the manifest editor and errors were reported for both cases after saving the file. It says that my header has an invalid format. Works for the Require-Bundle header as well. Am I missing something or is this working in 3.4?
(In reply to comment #4) you sure Curtis? I just tried now and have no errors.
Created attachment 79720 [details] Screenshot How about you tell me what I'm doing wrong? :) Screenshot shows the contents of manifest.mf with extra comma's and the error marker showing up. The full text of the error is "The value of header 'Import-Package' has invalid format". I get the same thing for problems in the require-bundle header. The markers show up if I am editing the manifest in the Plug-in Manifest Editor or with a Text Editor. I get the same result whether I have two commas or a dangling comma, as long as I save the file after any changes.
Oh no, it seems we have a ghost in someone's machines! I just tried it on my local machine with I20070920-0936 and it does not give me any errors. I have no clue what you are doing different Curtis...
I see the errors using I20071002-1342, but I didn't on I20070925-1406.
Adam, thanks for your help investigating this and figuring out the discrepancy. It appears the fix for bug 204614 had an interesting side effect, as in fixing this bug also :) Talk about two birds with one stone!
