Community
Participate
Working Groups
The XSD validator ID has changed with the implementation of https://bugs.eclipse.org/bugs/show_bug.cgi?id=132230. The XSD validation performance tests have this ID hardcoded in quite a few places. The validation framework cannot find the proper validator when looking it up based on the wrong ID and all XSD validation performance tests fail.
Hi Valentin, this one is yours.
In addition to the validator ID it appears that the XSD editor ID has changed as well. Together, these changes pretty much broke every test in this suite. Keith, can you comment on the editor ID change? Should I modify the test cases to adapt to the new editor ID or will the editor ID be reverted to the previous value to preserve backward compatibility?
Created attachment 44564 [details] Proposed fix Instead of simply replacing the many occurrences of the editor and validator IDs scattered across the code, I decided to refactor the code by introducing a couple of base classes. This will concentrate the references to these IDs in at most a few places. For the editor ID I've been able to reuse a constant defined in the XSDEditorPlugin. This will ensure that if the editor ID changes the change will be propagated here easily. Could not find a similar constant for the validator. Avoiding these "magic strings" https://bugs.eclipse.org/bugs/show_bug.cgi?id=136781 would go a long way to avoid breakages like this one. While I was at it, I updated the copyright headers and organized imports. I did a PDE build as well, so the plugin should build nicely. I was able to run most test (except the OAGIS ones, which I don't really know how to setup). Jeff, please test and feel free to commit if everything seems fine.
Patch committed
The tests still cannot run on the performance machine. The plugin jar file is missing test.xml.
Created attachment 45843 [details] Corrects build.properties
Comment on attachment 44564 [details] Proposed fix Already applied.
Comment on attachment 45843 [details] Corrects build.properties Patch applied.
Created attachment 46311 [details] New fixes Corrects the editor ID missed in one file. Corrects the package name for 6 scalability tests in test.xml.
Comment on attachment 46311 [details] New fixes Patch applied.
All tests are running now.
performance bugs should use performance keyword (not [performance] in subject).
Verified.
Closing.
