Bug 146692 - support a consistent and ample snap zone for wiring to all object types
Summary: support a consistent and ample snap zone for wiring to all object types
Status: RESOLVED FIXED
Alias: None
Product: GMF-Runtime
Classification: Modeling
Component: General (show other bugs)
Version: 1.0   Edit
Hardware: PC Windows XP
: P3 normal
Target Milestone: 1.0.1   Edit
Assignee: Alex Boyko CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2006-06-12 16:05 EDT by Michael Hanner CLA
Modified: 2010-07-19 12:27 EDT (History)
1 user (show)

See Also:


Attachments
fix for bug #146692 (1.98 KB, patch)
2006-08-02 16:06 EDT, Alex Boyko CLA
no flags Details | Diff
corrected patch (2.10 KB, patch)
2006-08-02 17:37 EDT, Alex Boyko CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Hanner CLA 2006-06-12 16:05:26 EDT
Problem: Snap functionality is supported, but it differs between diagram types. In some cases, there is no apparent snap zone outside a destination object. In one such case, once the mouse hits the destination object, the ghosted link line is snapped half an object width away while the mouse is still down. In other cases, there appears to be as much as half a centimeter of snap zone.

Solution: provide a consistent snap zone for wires to all object types. Allow the snap zone to extend a bit outside the object itself.
Comment 1 Steven R. Shaw CLA 2006-07-21 11:37:55 EDT
Though perhaps an increased snap-zone would help, I think a cursor change when overtop of a target object versus the diagram would be most valuable.  When over the diagram, the cursor should represent that fact that a menu will appear (arrow with mini menu decoration).  When over a target element, the regular (current cursor) would appear.  This would allow the user to immediately distinguish between the 2 use cases and provide them feedback as to what is going to happen when they release the mouse.
Comment 2 Alex Boyko CLA 2006-07-26 12:12:42 EDT
The bug is fixed as suggested by Steven (see comment #1). However, we need to come up with an image for a new cursor and commit the fix with the image files for the new cursor. The code has been reviewed.
Comment 3 Anthony Hunter CLA 2006-08-01 11:41:55 EDT
As discussed, we can use an existing icon for 1.0.1
Comment 4 Alex Boyko CLA 2006-08-02 16:06:00 EDT
Created attachment 47263 [details]
fix for bug #146692

The patch fixing the bug
Comment 5 Mohammed Mostafa CLA 2006-08-02 17:03:24 EDT
the patch breaks the disabled cursor use case use case in one of the clients
Comment 6 Alex Boyko CLA 2006-08-02 17:37:27 EDT
Created attachment 47277 [details]
corrected patch

Corrected patch is attached
Comment 7 Mohammed Mostafa CLA 2006-08-10 16:35:59 EDT
commited the patch
Comment 8 Alex Boyko CLA 2006-08-10 16:51:07 EDT
Marking as fixed, since patch is commited
Comment 9 Eclipse Webmaster CLA 2010-07-19 12:27:09 EDT
[GMF Restructure] Bug 319140 : product GMF and component
Runtime Diagram was the original product and component for this bug