Bug 146615 - [hierarchy] TypeHierarchyTests is tests order dependent
Summary: [hierarchy] TypeHierarchyTests is tests order dependent
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2.1   Edit
Assignee: Jerome Lanneluc CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 146015
  Show dependency tree
 
Reported: 2006-06-12 12:00 EDT by Frederic Fusier CLA
Modified: 2006-09-12 08:41 EDT (History)
0 users

See Also:

Attachments
Proposed fix (35.50 KB, patch)
2006-06-14 05:00 EDT, Jerome Lanneluc CLA 		no flags Details | Diff
Improved fix (35.48 KB, patch)
2006-06-14 06:48 EDT, Jerome Lanneluc CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Frederic Fusier CLA 2006-06-12 12:00:42 EDT 
bug 146015 follow-up

TypeHierarchyTests.testRegion4() fails if this test suite is run using -Dordering=700 VM argument.

Problem comes from the fact that with this specific order, jclMin.jar belongs sometimes to "TypeHierarchy" project instead of always belonging to "P1" project while running with default order.

I haven't found the reason of this difference, but the side effect is that while pruning dead branches of hierarchy, class files of jclMin.jar which belongs to "TypeHierarchy" project are removed because none of their ancestors matches region projects (ie. Region.contains(IJavaElement) returns false for these class files).
Comment 1 Frederic Fusier CLA 2006-06-12 12:04:21 EDT 
FYI: It also fails running with -Dordering=670
Comment 2 Jerome Lanneluc CLA 2006-06-14 05:00:32 EDT 
Created attachment 44390 [details]
Proposed fix
Comment 3 Philipe Mulet CLA 2006-06-14 05:36:08 EDT 
Fix seems like it should be extended to handle internal JAR from other projects as well (ie. all jar pkg fragment roots)
Comment 4 Jerome Lanneluc CLA 2006-06-14 06:48:16 EDT 
Created attachment 44391 [details]
Improved fix
Comment 5 Jerome Lanneluc CLA 2006-06-14 06:56:31 EDT 
Patch released for 3.3M1 in HEAD.
Comment 6 Jerome Lanneluc CLA 2006-06-14 07:31:51 EDT 
Patch released for 3.2.1 in TARGET_321 branch.
Comment 7 Frederic Fusier CLA 2006-08-07 07:48:53 EDT 
Verified for 3.3 M1 using build I20060807-0010.
Comment 8 David Audel CLA 2006-09-12 08:41:18 EDT 
Verified for 3.2.1 using build M20060908-1655