Bug 146556 - Should refactor boolean fields into bits
Summary: Should refactor boolean fields into bits
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P2 normal (vote)
Target Milestone: 3.3 M7   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2006-06-12 09:04 EDT by Philipe Mulet CLA
Modified: 2007-04-27 12:06 EDT (History)
1 user (show)

See Also:

Attachments
Proposed patch for a subset of the issues (42.59 KB, patch)
2007-04-12 06:35 EDT, Philipe Mulet CLA 		no flags Details | Diff
Patch for remaining issues (81.14 KB, patch)
2007-04-25 11:52 EDT, Olivier Thomann CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philipe Mulet CLA 2006-06-12 09:04:12 EDT 
Performing a search of boolean field decl "* boolean" in search dialog, any match in AST should be converted for using a tagbit instead.
Comment 1 Jerome Lanneluc CLA 2007-04-02 12:19:34 EDT 
To be investigated during 3.3 M7.
Comment 2 Philipe Mulet CLA 2007-04-12 06:35:48 EDT 
Created attachment 63595 [details]
Proposed patch for a subset of the issues

Removed:
  CaseStatement#isEnumConstant
  ExplicitConstructorCall#discardEnclosingInstance
  FieldDeclaration#hasBeenResolved
Comment 3 Philipe Mulet CLA 2007-04-12 06:36:33 EDT 
Patch released
Comment 4 Philipe Mulet CLA 2007-04-12 06:45:15 EDT 
Remaining issues:
  AbstractMethodDeclaration#errorInSignature
  AbstractMethodDeclaration#ignoreFurtherInvestigation (would keep this one)
  AbstractMethodDeclaration#needFreeReturn
  CompilationUnitDeclaration#... (would keep these - little instances)
  ConstructorDeclaration#isDefaultConstructor
  ForStatement#neededScope
  IfStatement#thenExit
  ImportReference#onDemand
  ImportReference#used
  Initializer#errorInSignature
  JavadocAllocationExpression#superAccess
  JavadocFieldReference#superAccess
  JavadocMessageSend#superAccess
  JavadocReturnStatement#empty
  ParameterizedQualifiedTypeReference#didResolve
  ParameterizedSingleTypeReference#didResolve
  ReturnStatement#isAnySubRoutineEscaping
  ReturnStatement#isSynchronized
  SynchronizedStatement#blockExit
  TypeDeclaration#hasBeenGenerated
  TypeDeclaration#ignoreFurtherInvestigation (would keep this)
Comment 5 Olivier Thomann CLA 2007-04-25 11:52:30 EDT 
Created attachment 64883 [details]
Patch for remaining issues
Comment 6 Olivier Thomann CLA 2007-04-25 12:59:09 EDT 
Released for 3.3M7.
To verify, the patch needs to be checked.
Comment 7 Maxime Daniel CLA 2007-04-27 12:06:20 EDT 
Verified for 3.3 M7 using source code v_751.
(Checked that remaining boolean field declarations in AST match the cases marked as 'would keep' above - a total of five instances.)