Bug 146254 - MBSCustomPage needs required pageID on ctor
Summary: MBSCustomPage needs required pageID on ctor
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-core (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.1   Edit
Assignee: Chris Recoskie CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2006-06-09 10:03 EDT by Beth Tibbitts CLA
Modified: 2009-01-09 16:50 EST (History)
0 users

See Also:

Attachments
Add a constructor which requires the pageID; make the default ctor deprecated (1.23 KB, patch)
2006-06-09 10:48 EDT, Beth Tibbitts CLA 		bjorn.freeman-benson: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Tibbitts CLA 2006-06-09 10:03:21 EDT 
When extending MBSCustomPage to add a new project wizard page in after the default CDT new project wizard pages, the pageID must be set in the class that extends MBSCustomPage.  Since this is required, it makes sense to make the only constructor require this as an argument...

e.g. MBSCustomPage(String pageID)
instead of the default constructor only.

I will append a patch that does this and makes the default constructor deprecated.
Comment 1 Beth Tibbitts CLA 2006-06-09 10:48:41 EDT 
Created attachment 43986 [details]
Add a constructor which requires the pageID; make the default ctor deprecated
Comment 2 Chris Recoskie CLA 2006-06-09 11:06:01 EDT 
This is pretty trivial and breaks no API so I see no reason not to do this for 3.1
Comment 3 Chris Recoskie CLA 2006-06-12 09:25:13 EDT 
Applied to head, with an accompanying change to the copyright header.