Bug 146214 - Refactor XmlWritter and Main.Logger
Summary: Refactor XmlWritter and Main.Logger
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3 M1   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-06-09 06:07 EDT by Jerome Lanneluc CLA
Modified: 2006-08-08 04:06 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jerome Lanneluc CLA 2006-06-09 06:07:53 EDT 
3.2 RC7

Some methods of Main.Logger like printTag(...) (and maybe other) are a plain copy of the same methods in XmlWritter. These should be refactored so that we don't have to do the same change in 2 places.

A good place would be org.eclipse.jdt.internal.compiler.util.
Comment 1 Olivier Thomann CLA 2006-06-21 13:00:45 EDT 
Fixed and released in HEAD.
No regression test needed as this is a refactoring of existing code.
Comment 2 Frederic Fusier CLA 2006-08-03 08:46:50 EDT 
Released for 3.3 M1
Comment 3 Frederic Fusier CLA 2006-08-08 04:06:27 EDT 
Verified for 3.3 M1 using build I20060807-2000.