Bug 145863 - Colors defined in the gmfgraph model should be used by the generated polyline connections
Summary: Colors defined in the gmfgraph model should be used by the generated polyline...
Status: RESOLVED FIXED
Alias: None
Product: GMF-Tooling (ARCHIVED)
Classification: Modeling
Component: Core (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Michael Golubev CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2006-06-07 16:08 EDT by Michael Golubev CLA
Modified: 2010-07-19 22:21 EDT (History)
0 users

See Also:


Attachments
Fixes the subj (116.57 KB, patch)
2006-06-14 20:09 EDT, Michael Golubev CLA
no flags Details | Diff
Fixes the subj (123.03 KB, patch)
2006-06-19 07:01 EDT, Michael Golubev CLA
no flags Details | Diff
Additional fix for tests in the lite mode (9.01 KB, patch)
2006-06-19 10:36 EDT, Michael Golubev CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Golubev CLA 2006-06-07 16:08:44 EDT
Actually (see news:e6720s$v3s$1@utils.eclipse.org) it is impossible to make polyline connection to be colored by the color defined in gmfgraph model.

It is because the default color from preferences is always set to the just created notation Edge.

Expected: In case if color is set to the polyline instance in the gmfgraph model, ViewFactory should be aware of it and produce Notation edge's with this color.
Comment 1 Michael Golubev CLA 2006-06-14 20:09:17 EDT
Created attachment 44468 [details]
Fixes the subj

GeneratedPropertiesAttributes introduced to gmfgen model to state the properties processed at the gmfgraph level. These properties mow includes font, fore/background colors. All of these properties are set by ViewmapProducer. Howewer, in the current fix, only value for foreground color is read by gmfgen and only while processing GenLink's. Other properties are reserved for future use (intended to be used the same way as in current fix).

ViewFactory generator checks whether link's color is set in the gmfgraph code and if yes, generator supresses creation of the default LineStyle for just created Edge. At the same time, other properties of the ConnectorStyle remains unchanged.
Comment 2 Michael Golubev CLA 2006-06-19 07:01:23 EDT
Created attachment 44808 [details]
Fixes the subj

In contrast to the previous version, now generated ViewFactory always overrides createStyles method. Explicit control over the set of created Styles allows us to avoid the hack-like removing of undesired styles in the decorateView() mathod.

Also new Attributes class was renamed to StyleAttributes with more clear properties/methods names.
Comment 3 Alex Shatalin CLA 2006-06-19 08:38:35 EDT
commited
Comment 4 Michael Golubev CLA 2006-06-19 10:36:01 EDT
Created attachment 44816 [details]
Additional fix for tests in the lite mode 

The problem described in the bug is runtime-specific. 
However, after fix was applied, some of lite-mode tests were failed because of introduced dependecies and internal lite problems.

This patch is intended to fix it.
Comment 5 Alex Shatalin CLA 2006-06-19 13:25:09 EDT
Patch for the lite mode tests commited.
Comment 6 Eclipse Webmaster CLA 2010-07-19 22:21:20 EDT
[GMF Restructure] Bug 319140 : product GMF and component
Generation was the original product and component for this bug