Bug 145467 - Problems when using the "avoid obstructions" setting for connections
Summary: Problems when using the "avoid obstructions" setting for connections
Status: RESOLVED DUPLICATE of bug 110725
Alias: None
Product: GMF-Runtime
Classification: Modeling
Component: General (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal
Target Milestone: 2.0   Edit
Assignee: Alex Boyko CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2006-06-06 02:15 EDT by Pratik Shah CLA
Modified: 2010-07-19 12:28 EDT (History)
2 users (show)

See Also:

Attachments
Fix for bug #145467 (1.16 KB, patch)
2006-07-20 14:10 EDT, Alex Boyko CLA 		no flags Details | Diff
Improved fix (2.29 KB, patch)
2006-07-20 16:59 EDT, Alex Boyko CLA 		no flags Details | Diff
Fix for bug #145467 with comments (2.61 KB, patch)
2006-07-26 11:19 EDT, Alex Boyko CLA 		no flags Details | Diff
patch merged (2.53 KB, patch)
2006-08-03 09:34 EDT, Alex Boyko CLA 		no flags Details | Diff
patch merged (2.53 KB, patch)
2006-08-03 09:50 EDT, Alex Boyko CLA 		no flags Details | Diff
merged fix (2.59 KB, patch)
2006-08-03 10:54 EDT, Alex Boyko CLA 		no flags Details | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pratik Shah CLA 2006-06-06 02:15:44 EDT 
Using 1.0RC4

1) Connections that avoid obstructions don't support manual bendpoints.

2) If you try to create a manual bendpoint, nothing happens.  However, it seems a command is executed and the file is marked dirty.

3) Connections that avoid obstuctions need to be re-routed when editparts not connected to that connection are moved, since such editparts may have gotten in the connection's way.  Since that doesn't happen currently, you can move a part in a connection's path and it won't re-route around it.

All these problems can be reproduced in the GMF logic example.
Comment 1 Alex Shatalin CLA 2006-06-20 07:03:14 EDT 
Changing component.
Comment 2 Steven R. Shaw CLA 2006-06-20 09:14:16 EDT 
(3) is a duplicate of 110725.

Note: GEF router can switched on in RouterHelper using variable useGEFRouter. There were some issues around redundant bendpoints and comparative results that prevented full integration.
Comment 3 Steven R. Shaw CLA 2006-06-27 11:03:55 EDT 
targetting 1.0.1.  At least (2.) should be addressed to avoid dirtying the diagram.
Comment 4 Alex Boyko CLA 2006-07-20 14:10:07 EDT 
Created attachment 46592 [details]
Fix for bug #145467

The fix for the bug part #2 only (3 parts total)
Comment 5 Alex Boyko CLA 2006-07-20 16:59:11 EDT 
Created attachment 46603 [details]
Improved fix

Again the fix for section 2 of the bug. Simply forgot to include in the patch another file to display the cursor correctly
Comment 6 Alex Boyko CLA 2006-07-26 11:19:28 EDT 
Created attachment 46820 [details]
Fix for bug #145467 with comments

Explained some of the changes (i.e. Added comment)
Comment 7 Alex Boyko CLA 2006-07-27 11:17:06 EDT 
This bug is fixed and the code reviewed. Assigning it to Anthony for making the decision whether it should make it into the release
Comment 8 Anthony Hunter CLA 2006-08-01 11:13:02 EDT 
Mohammed did the code review so he will commit.
Comment 9 Mohammed Mostafa CLA 2006-08-02 17:12:50 EDT 
the patch is not working, it looks like some files are missing from the patch
please update it
Comment 10 Alex Boyko CLA 2006-08-03 09:34:05 EDT 
Created attachment 47317 [details]
patch merged

Due to the code changes to ConnectionEditPart the patch had to be updated. Here is the updated patch
Comment 11 Alex Boyko CLA 2006-08-03 09:50:33 EDT 
Created attachment 47319 [details]
patch merged

Due to the code changes to ConnectionEditPart the patch had to be updated. Here is the updated patch
Comment 12 Alex Boyko CLA 2006-08-03 10:54:56 EDT 
Created attachment 47326 [details]
merged fix

Changed the device for the cursor to default one
Comment 13 Mohammed Mostafa CLA 2006-08-10 16:36:30 EDT 
commited the patch
Comment 14 Alex Boyko CLA 2006-08-11 09:18:39 EDT 
The fix for 1 and 2 is commited. User won't be able to create extra bend ponits when "avoid obstructions" is on
Comment 15 Richard Gronback CLA 2006-08-23 18:58:01 EDT 
Note that the commit comment for this bug indicates it is #144567
Comment 16 Alex Boyko CLA 2006-09-08 10:13:59 EDT 
Part 3 will be addressed and maybe 1 (if we allow users to create bend points when "avoid obstructions" is on) in 2.0
Comment 17 Alex Boyko CLA 2006-12-08 11:51:57 EST 
Part 3) is a duplicate of 110725

*** This bug has been marked as a duplicate of bug 110725 ***
Comment 18 Eclipse Webmaster CLA 2010-07-19 12:28:46 EDT 
[GMF Restructure] Bug 319140 : product GMF and component
Runtime Diagram was the original product and component for this bug